[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230516-footprint-handoff-bcd553ff6146@spud>
Date: Tue, 16 May 2023 19:06:35 +0100
From: Conor Dooley <conor@...nel.org>
To: Sean Nyekjaer <sean@...nix.com>
Cc: robh+dt@...nel.org, Lee Jones <lee@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
pascal Paillet <p.paillet@...s.st.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: mfd: stpmic1: add fsl,pmic-poweroff
property
Hey Sean,
On Tue, May 16, 2023 at 03:22:24PM +0200, Sean Nyekjaer wrote:
> Document the new optional "fsl,pmic-poweroff" property.
>
> Signed-off-by: Sean Nyekjaer <sean@...nix.com>
> ---
> Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> index 9573e4af949e..5183a7c660d2 100644
> --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> @@ -26,6 +26,14 @@ properties:
>
> interrupt-controller: true
>
> + st,pmic-poweroff:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: |
> + if present, configure the PMIC to shutdown all power rails when
> + power off sequence have finished.
> + Use this option if the SoC should be powered off by external power management
> + IC (PMIC).
Just reading this description, this is sounding quite like a "software
behaviour" type of property, which are not permitted, rather than
describing some element of the hardware. Clearly you are trying to solve
an actual problem though, so try re-phrasing the description (and
property name) to focus on what exact hardware configuration it is that
you are trying to special-case.
Krzysztof suggested that the samsung,s2mps11-acokb-ground property in
samsung,s2mps11.yaml is addressing a similar problem, so that could be
good to look at.
Also, the dt-binding patch should go before the patch adding the
property to the driver.
Thanks,
Conor.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists