linux-kernel - Re: [PATCH] phy: ti: gmii-sel: Allow parent to not be syscon node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ae4bd37-65ee-d6da-1ab6-c1018d9959ec@ti.com>
Date:   Tue, 16 May 2023 09:35:56 +0530
From:   Siddharth Vadapalli <s-vadapalli@...com>
To:     Andrew Davis <afd@...com>
CC:     Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Roger Quadros <rogerq@...nel.org>,
        <linux-phy@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <s-vadapalli@...com>
Subject: Re: [PATCH] phy: ti: gmii-sel: Allow parent to not be syscon node

Andrew,

On 16/05/23 01:29, Andrew Davis wrote:
> If the parent node is not a syscon type, then fallback and check
> if we can get a regmap from our own node. This no longer forces
> us to make the parent of this node a syscon node when that might
> not be appropriate.

Could you please let me know in which cases it is appropriate versus in which
cases it isn't? Is syscon_node_to_regmap() being retained for backward
compatibility until the device-tree nodes are cleaned up across all devices?

> 
> Signed-off-by: Andrew Davis <afd@...com>
> ---
>  drivers/phy/ti/phy-gmii-sel.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c
> index 8c667819c39a..1e67ed9a5cf6 100644
> --- a/drivers/phy/ti/phy-gmii-sel.c
> +++ b/drivers/phy/ti/phy-gmii-sel.c
> @@ -435,9 +435,12 @@ static int phy_gmii_sel_probe(struct platform_device *pdev)
>  
>  	priv->regmap = syscon_node_to_regmap(node->parent);
>  	if (IS_ERR(priv->regmap)) {
> -		ret = PTR_ERR(priv->regmap);
> -		dev_err(dev, "Failed to get syscon %d\n", ret);
> -		return ret;
> +		priv->regmap = device_node_to_regmap(node);

If device_node_to_regmap() can always be used with the corresponding changes
made to the device-tree nodes, wouldn't it be better to use it directly instead
of using it as a fallback? (This is based on the assumption that
syscon_node_to_regmap() is only being retained until the device-tree nodes are
cleaned up to work with device_node_to_regmap()).

> +		if (IS_ERR(priv->regmap)) {
> +			ret = PTR_ERR(priv->regmap);
> +			dev_err(dev, "Failed to get syscon %d\n", ret);
> +			return ret;
> +		}
>  	}
>  
>  	ret = phy_gmii_sel_init_ports(priv);

-- 
Regards,
Siddharth.