lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202305170205.4sQpYbDU-lkp@intel.com>
Date:   Wed, 17 May 2023 03:01:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sven Schnelle <svens@...ux.ibm.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Frederic Weisbecker <frederic@...nel.org>,
        "Eric W . Biederman" <ebiederm@...ssion.com>,
        Mark Rutland <mark.rutland@....com>,
        Andy Lutomirski <luto@...nel.org>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-s390@...r.kernel.org, hca@...ux.ibm.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] entry: move the exit path to header files

Hi Sven,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/core/entry]
[also build test ERROR on linus/master v6.4-rc2 next-20230516]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sven-Schnelle/entry-move-the-exit-path-to-header-files/20230516-230146
base:   tip/core/entry
patch link:    https://lore.kernel.org/r/20230516133810.171487-2-svens%40linux.ibm.com
patch subject: [PATCH 1/2] entry: move the exit path to header files
config: i386-buildonly-randconfig-r001-20230515
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/30656e2ff97c145a735ce61be030ba945ec99ace
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sven-Schnelle/entry-move-the-exit-path-to-header-files/20230516-230146
        git checkout 30656e2ff97c145a735ce61be030ba945ec99ace
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kernel/ kernel/entry/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305170205.4sQpYbDU-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from arch/x86/kernel/signal.c:28:
>> include/linux/entry-common.h:572:2: error: implicit declaration of function 'audit_syscall_exit' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           audit_syscall_exit(regs);
           ^
   1 error generated.
--
   In file included from arch/x86/kernel/doublefault_32.c:11:
   In file included from arch/x86/include/asm/traps.h:9:
   In file included from arch/x86/include/asm/idtentry.h:11:
>> include/linux/entry-common.h:572:2: error: implicit declaration of function 'audit_syscall_exit' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           audit_syscall_exit(regs);
           ^
   arch/x86/kernel/doublefault_32.c:23:36: warning: no previous prototype for function 'doublefault_shim' [-Wmissing-prototypes]
   asmlinkage noinstr void __noreturn doublefault_shim(void)
                                      ^
   arch/x86/kernel/doublefault_32.c:23:20: note: declare 'static' if the function is not intended to be used outside of this translation unit
   asmlinkage noinstr void __noreturn doublefault_shim(void)
                      ^
                      static 
   arch/x86/kernel/doublefault_32.c:114:6: warning: no previous prototype for function 'doublefault_init_cpu_tss' [-Wmissing-prototypes]
   void doublefault_init_cpu_tss(void)
        ^
   arch/x86/kernel/doublefault_32.c:114:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void doublefault_init_cpu_tss(void)
   ^
   static 
   2 warnings and 1 error generated.
--
   In file included from kernel/entry/common.c:4:
>> include/linux/entry-common.h:572:2: error: implicit declaration of function 'audit_syscall_exit' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           audit_syscall_exit(regs);
           ^
   In file included from kernel/entry/common.c:10:
   include/linux/audit.h:591:20: error: static declaration of 'audit_syscall_exit' follows non-static declaration
   static inline void audit_syscall_exit(void *pt_regs)
                      ^
   include/linux/entry-common.h:572:2: note: previous implicit declaration is here
           audit_syscall_exit(regs);
           ^
   2 errors generated.
--
   In file included from arch/x86/kernel/fpu/core.c:14:
   In file included from arch/x86/include/asm/traps.h:9:
   In file included from arch/x86/include/asm/idtentry.h:11:
>> include/linux/entry-common.h:572:2: error: implicit declaration of function 'audit_syscall_exit' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           audit_syscall_exit(regs);
           ^
   In file included from arch/x86/kernel/fpu/core.c:29:
   In file included from arch/x86/include/asm/trace/fpu.h:99:
>> include/trace/define_trace.h:95:10: fatal error: 'asm/trace//syscalls.h' file not found
   #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/define_trace.h:90:32: note: expanded from macro 'TRACE_INCLUDE'
   # define TRACE_INCLUDE(system) __TRACE_INCLUDE(system)
                                  ^~~~~~~~~~~~~~~~~~~~~~~
   include/trace/define_trace.h:87:34: note: expanded from macro '__TRACE_INCLUDE'
   # define __TRACE_INCLUDE(system) __stringify(TRACE_INCLUDE_PATH/system.h)
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/stringify.h:10:27: note: expanded from macro '__stringify'
   #define __stringify(x...)       __stringify_1(x)
                                   ^~~~~~~~~~~~~~~~
   include/linux/stringify.h:9:29: note: expanded from macro '__stringify_1'
   #define __stringify_1(x...)     #x
                                   ^~
   <scratch space>:264:1: note: expanded from here
   "asm/trace//syscalls.h"
   ^~~~~~~~~~~~~~~~~~~~~~~
   2 errors generated.


vim +/audit_syscall_exit +572 include/linux/entry-common.h

   554	
   555	static void syscall_exit_work(struct pt_regs *regs, unsigned long work)
   556	{
   557		bool step;
   558	
   559		/*
   560		 * If the syscall was rolled back due to syscall user dispatching,
   561		 * then the tracers below are not invoked for the same reason as
   562		 * the entry side was not invoked in syscall_trace_enter(): The ABI
   563		 * of these syscalls is unknown.
   564		 */
   565		if (work & SYSCALL_WORK_SYSCALL_USER_DISPATCH) {
   566			if (unlikely(current->syscall_dispatch.on_dispatch)) {
   567				current->syscall_dispatch.on_dispatch = false;
   568				return;
   569			}
   570		}
   571	
 > 572		audit_syscall_exit(regs);
   573	
   574		if (work & SYSCALL_WORK_SYSCALL_TRACEPOINT)
   575			trace_sys_exit(regs, syscall_get_return_value(current, regs));
   576	
   577		step = report_single_step(work);
   578		if (step || work & SYSCALL_WORK_SYSCALL_TRACE)
   579			ptrace_report_syscall_exit(regs, step);
   580	}
   581	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (196509 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ