linux-kernel - Re: [PATCH v2] x86/resctrl: Only show tasks' pid in current pid namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ace6ad64-75a9-716a-8845-9a2c92820dda@intel.com>
Date:   Tue, 16 May 2023 12:04:03 -0700
From:   Fenghua Yu <fenghua.yu@...el.com>
To:     Shawn Wang <shawnwang@...ux.alibaba.com>,
        <reinette.chatre@...el.com>
CC:     <tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
        <dave.hansen@...ux.intel.com>, <x86@...nel.org>, <hpa@...or.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] x86/resctrl: Only show tasks' pid in current pid
 namespace


On 5/14/23 23:04, Shawn Wang wrote:
> When writing a task id to the "tasks" file in an rdtgroup,
> rdtgroup_tasks_write() treats the pid as a number in the current pid
> namespace. But when reading the "tasks" file, rdtgroup_tasks_show() shows
> the list of global pids from the init namespace, which is confusing and
> incorrect.
> 
> To be more robust, let the "tasks" file only show pids in the current pid
> namespace.
> 
> Link: https://lore.kernel.org/all/20230116071246.97717-1-shawnwang@linux.alibaba.com/
> Fixes: e02737d5b826 ("x86/intel_rdt: Add tasks files")
> Signed-off-by: Shawn Wang <shawnwang@...ux.alibaba.com>
> Tested-by: Reinette Chatre <reinette.chatre@...el.com>
> Acked-by: Reinette Chatre <reinette.chatre@...el.com>

Acked-by: Fenghua Yu <fenghua.yu@...el.com>

Thanks.

-Fenghua