linux-kernel - Re: [PATCH] hsi: fix ssi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202305161330.FE7311B@keescook>
Date:   Tue, 16 May 2023 13:30:35 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Carlos Chinea <carlos.chinea@...ia.com>,
        Arnd Bergmann <arnd@...db.de>,
        Jianglei Nie <niejianglei2021@....com>,
        Nathan Chancellor <nathan@...nel.org>,
        Wang Qing <wangqing@...o.com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Yuan Can <yuancan@...wei.com>,
        Miaoqian Lin <linmq006@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hsi: fix ssi_waketest() declaration

On Tue, May 16, 2023 at 10:22:07PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The ssi_waketest() function definition causes a 'make W=1' warning
> because the declaration is hidden away in ssi_protocol.c:
> 
> drivers/hsi/controllers/omap_ssi_core.c:147:6: error: no previous prototype for 'ssi_waketest'
> 
> Move it into a header file instead.
> 
> Fixes: dc7bf5d71868 ("HSI: Introduce driver for SSI Protocol")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook