linux-kernel - Re: [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230516-onslaught-conceded-8e27b4bc7e4a@spud>
Date:   Tue, 16 May 2023 22:20:06 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Tim Harvey <tharvey@...eworks.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Li Yang <leoyang.li@....com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary
 fan-controller nodes

Hey Tim,

On Tue, May 16, 2023 at 08:33:13AM -0700, Tim Harvey wrote:
> Remove the unnecessary #address-cells and #size-cells nodes from
> the fan-controller.

It'd be nice to mentioned _why_ they are redundant, since the diff
doesn't contain that context.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

> 
> Signed-off-by: Tim Harvey <tharvey@...eworks.com>
> ---
>  .../devicetree/bindings/mfd/gateworks-gsc.yaml         | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> index acb9c54942d9..dc379f3ebf24 100644
> --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> @@ -122,12 +122,6 @@ patternProperties:
>        compatible:
>          const: gw,gsc-fan
>  
> -      "#address-cells":
> -        const: 1
> -
> -      "#size-cells":
> -        const: 0
> -
>        reg:
>          description: The fan controller base address
>          maxItems: 1
> @@ -135,8 +129,6 @@ patternProperties:
>      required:
>        - compatible
>        - reg
> -      - "#address-cells"
> -      - "#size-cells"
>  
>  required:
>    - compatible
> @@ -194,8 +186,6 @@ examples:
>              };
>  
>              fan-controller@2c {
> -                #address-cells = <1>;
> -                #size-cells = <0>;
>                  compatible = "gw,gsc-fan";
>                  reg = <0x2c>;
>              };
> -- 
> 2.25.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)