linux-kernel - Re: [PATCH v8 05/14] mfd: rk808: split into core and i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 May 2023 00:01:27 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Marek Szyprowski <m.szyprowski@...sung.com>
Cc:     Heiko Stuebner <heiko@...ech.de>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lee Jones <lee@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com,
        Diederik de Haas <didi.debian@...ow.org>,
        Vincent Legoll <vincent.legoll@...il.com>
Subject: Re: [PATCH v8 05/14] mfd: rk808: split into core and i2c

Hello Marek,

On Tue, May 16, 2023 at 11:26:59PM +0200, Marek Szyprowski wrote:
> Hi,
> 
> On 04.05.2023 19:36, Sebastian Reichel wrote:
> > Split rk808 into a core and an i2c part in preparation for
> > SPI support.
> >
> > Acked-for-MFD-by: Lee Jones <lee@...nel.org>
> > Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com> # for RTC
> > Tested-by: Diederik de Haas <didi.debian@...ow.org> # Rock64, Quartz64 Model A + B
> > Tested-by: Vincent Legoll <vincent.legoll@...il.com> # Pine64 QuartzPro64
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> 
> This patch landed in today's linux-next as commit c20e8c5b1203 ("mfd: 
> rk808: Split into core and i2c"). Unfortunately some boards (for example 
> Hardkernel's Odroid-M1) stopped to boot after this change. This is 
> caused by the lack of updating the related defconfigs. Could you please 
> add a patch that updates the MFD_RK808 entries to MFD_RK8XX_I2C in the 
> following files:
> 
> $ git grep MFD_RK808
> arch/arm/configs/multi_v7_defconfig:CONFIG_MFD_RK808=y
> arch/arm64/configs/defconfig:CONFIG_MFD_RK808=y

Sure, I will prepare a patch for each of them. Thanks for the quick
report and sorry for the inconvenience.

-- Sebastian

> 
> 
> > ---
> >   drivers/clk/Kconfig                   |   2 +-
> >   drivers/input/misc/Kconfig            |   2 +-
> >   drivers/mfd/Kconfig                   |   7 +-
> >   drivers/mfd/Makefile                  |   3 +-
> >   drivers/mfd/{rk808.c => rk8xx-core.c} | 209 +++++---------------------
> >   drivers/mfd/rk8xx-i2c.c               | 200 ++++++++++++++++++++++++
> >   drivers/pinctrl/Kconfig               |   2 +-
> >   drivers/power/supply/Kconfig          |   2 +-
> >   drivers/regulator/Kconfig             |   2 +-
> >   drivers/rtc/Kconfig                   |   2 +-
> >   include/linux/mfd/rk808.h             |   6 +
> >   sound/soc/codecs/Kconfig              |   2 +-
> >   12 files changed, 256 insertions(+), 183 deletions(-)
> >   rename drivers/mfd/{rk808.c => rk8xx-core.c} (76%)
> >   create mode 100644 drivers/mfd/rk8xx-i2c.c
> >
> > ...
> 
> Best regards
> -- 
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)