linux-kernel - Re: [PATCH v3 0/6] sysctl: Remove register_sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZGQMsKiZUZg+5mFb@bombadil.infradead.org>
Date:   Tue, 16 May 2023 16:07:28 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Joel Granados <j.granados@...sung.com>
Cc:     Kees Cook <keescook@...omium.org>, linux-fsdevel@...r.kernel.org,
        Iurii Zaikin <yzaikin@...gle.com>,
        linux-kernel@...r.kernel.org,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: Re: [PATCH v3 0/6] sysctl: Remove register_sysctl_table from parport

On Tue, May 16, 2023 at 06:28:57PM +0200, Joel Granados wrote:
> This is part of the general push to deprecate register_sysctl_paths and
> register_sysctl_table. Parport driver uses the "CHILD" pointer
> in the ctl_table structure to create its directory structure. We move to
> the newer register_sysctl call and remove the pointer madness.
> 
> I have separated the parport into 5 patches to clarify the different
> changes needed for the 3 calls to register_sysctl_paths. I can squash
> them together if need be.
> 
> We no longer export the register_sysctl_table call as parport was the
> last user from outside proc_sysctl.c. Also modified documentation slightly
> so register_sysctl_table is no longer mentioned.
> 
> V2:
> * Added a return error value when register fails
> * Made sure to free the memory on error when calling parport_proc_register
> * Added a bloat-o-meter output to measure bloat
> * Replaced kmalloc with kzalloc
> * Added comments about testing
> * Improved readability when using snprintf

Thanks, applied and pushed!

  Luis