linux-kernel - Re: [PATCH v3 2/3] leds: simatic-ipc-leds-gpio: split up into multiple drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 May 2023 09:09:06 +0200
From:   Henning Schild <henning.schild@...mens.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v3 2/3] leds: simatic-ipc-leds-gpio: split up into
 multiple drivers

Am Tue, 16 May 2023 00:41:30 +0300
schrieb Andy Shevchenko <andriy.shevchenko@...ux.intel.com>:

> On Mon, May 15, 2023 at 05:03:51PM +0200, Henning Schild wrote:
> > In order to clearly describe the dependencies between the GPIO
> > controller drivers and the users the driver is split up into a core,
> > two drivers and a common header.  
> 
> AFAIU the GPIO lookup tables need a terminator entry.

They never had one in the first place and that worked, i did not add
terminators here and that also works. My guess is that .num_leds =
ARRAY_SIZE(simatic_ipc_gpio_leds) tells "leds-gpio" how many entries
there are. (another array without a terminator)

But i will add them in a v4 so things are explicit and aligned with
other similar drivers.

Henning