linux-kernel - Re: [PATCH 36/43] pwm: ep93xx: drop legacy pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 May 2023 13:43:27 +0300
From:   Nikita Shubin <nikita.shubin@...uefel.me>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Arnd Bergmann <arnd@...nel.org>, Linus Walleij <linusw@...nel.org>,
        Alexander Sverdlin <alexander.sverdlin@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 36/43] pwm: ep93xx: drop legacy pinctrl

Hello Uwe!

On Mon, 2023-05-15 at 16:32 +0200, Uwe Kleine-König wrote:
> On Mon, Apr 24, 2023 at 03:34:52PM +0300, Nikita Shubin wrote:
> > Drop legacy gpio request/free since we are using
> > pinctrl for this now.
> > 
> > Signed-off-by: Nikita Shubin <nikita.shubin@...uefel.me>
> > ---
> >  drivers/pwm/pwm-ep93xx.c | 16 ----------------
> >  1 file changed, 16 deletions(-)
> > 
> > diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-ep93xx.c
> > index 8bfe6cfbb3db..657adb011aeb 100644
> > --- a/drivers/pwm/pwm-ep93xx.c
> > +++ b/drivers/pwm/pwm-ep93xx.c
> > @@ -45,20 +45,6 @@ static inline struct ep93xx_pwm
> > *to_ep93xx_pwm(struct pwm_chip *chip)
> >         return container_of(chip, struct ep93xx_pwm, chip);
> >  }
> >  
> > -static int ep93xx_pwm_request(struct pwm_chip *chip, struct
> > pwm_device *pwm)
> > -{
> > -       struct platform_device *pdev = to_platform_device(chip-
> > >dev);
> > -
> > -       return ep93xx_pwm_acquire_gpio(pdev);
> 
> I didn't get the whole series and didn't spot a relevant followup
> change

https://lore.kernel.org/all/20230424123522.18302-1-nikita.shubin@maquefel.me/

> on lore.k.o, so: I assume ep93xx_pwm_acquire_gpio() and
> ep93xx_pwm_release_gpio() will be unused in the end? Do you drop
> them?
> 
> I assume this series target to be taken via arm-soc (once the review
> feedback is positive)?
> 
> I wonder if this change breaks non-dt machine support?

The aim for the whole series is fully converting to dt, this means
platform files will be dropped.

The v1 series tries not to break anything until platform removal
commit, before this commit non-dt version should be compilable and
fully functional.

> 
> Best regards
> Uwe
>