[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ab9aa30f-82d7-1d14-5561-e19ff10af0b0@linaro.org>
Date: Tue, 16 May 2023 10:07:47 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Julien Stephan <jstephan@...libre.com>
Cc: robh@...nel.org, chunkuang.hu@...nel.org,
linux-mediatek@...ts.infradead.org,
Florian Sylvestre <fsylvestre@...libre.com>,
Chunfeng Yun <chunfeng.yun@...iatek.com>,
Andy Hsieh <andy.hsieh@...iatek.com>,
Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
"moderated list:ARM/Mediatek USB3 PHY DRIVER"
<linux-arm-kernel@...ts.infradead.org>,
"open list:GENERIC PHY FRAMEWORK" <linux-phy@...ts.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: add mediatek mipi csi driver v
0.5
On 15/05/2023 11:05, Julien Stephan wrote:
> From: Florian Sylvestre <fsylvestre@...libre.com>
>
> This adds the bindings, for the MIPI CD-PHY module v 0.5 embedded in
> some Mediatek soc, such as the mt8365
>
> Signed-off-by: Florian Sylvestre <fsylvestre@...libre.com>
> Signed-off-by: Julien Stephan <jstephan@...libre.com>
What are the changes? IOW: changelog here or in cover letter.
Subject: you have some multiple spaces.
Subject: drop driver. Bindings are not for drivers.
> ---
> .../phy/mediatek,phy-mipi-csi-0-5.yaml | 62 +++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 68 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/mediatek,phy-mipi-csi-0-5.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,phy-mipi-csi-0-5.yaml b/Documentation/devicetree/bindings/phy/mediatek,phy-mipi-csi-0-5.yaml
> new file mode 100644
> index 000000000000..5aa8c0b41cdf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/mediatek,phy-mipi-csi-0-5.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-Only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/mediatek,phy-mipi-csi-0-5.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek Sensor Interface MIPI CSI CD-PHY
> +
> +maintainers:
> + - Julien Stephan <jstephan@...libre.com>
> + - Andy Hsieh <andy.hsieh@...iatek.com>
> +
> +description:
> + The SENINF CD-PHY is a set of CD-PHY connected to the SENINF CSI-2
> + receivers. The number of PHYs depends on the SoC model.
> + Depending on the soc model, each PHYs can support CDPHY or DPHY only
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,phy-mipi-csi-0-5
SoC based compatibles. 0-5 is odd.
> +
> + reg:
> + maxItems: 1
> +
> + '#phy-cells':
> + const: 0
> +
> + mediatek,is_cdphy:
No underscores in node names.
> + description:
> + Specify if the current phy support CDPHY configuration
Why this cannot be implied from compatible? Add specific compatibles.
> + type: boolean
> +
> +required:
> + - compatible
> + - reg
> + - '#phy-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + mipi_rx_csi0: mipi_rx_csi0@...10000 {
No underscores in node names. How this is v2?
> + compatible = "mediatek,phy-mipi-csi-0-5";
> + reg = <0 0x11C10000 0 0x2000>;
> + status = "okay";
Drop
> + mediatek,is_cdphy;
> + #phy-cells = <0>;
> + };
> +
> + mipi_rx_csi1: mipi-rx-csi1@...12000 {
> + compatible = "mediatek,phy-mipi-csi-0-5";
> + reg = <0 0x11C12000 0 0x2000>;
> + status = "disabled";
???
Best regards,
Krzysztof
Powered by blists - more mailing lists