linux-kernel - RE: [EXT] Re: [PATCH 1/2 v7] dt-bindings: watchdog: marvell GTI system watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 May 2023 10:06:26 +0000
From:   Sunil Kovvuri Goutham <sgoutham@...vell.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Bharat Bhushan <bbhushan2@...vell.com>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH 1/2 v7] dt-bindings: watchdog: marvell GTI
 system watchdog driver



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Tuesday, May 9, 2023 6:36 PM
> To: Bharat Bhushan <bbhushan2@...vell.com>; wim@...ux-watchdog.org;
> linux@...ck-us.net; robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> linux-watchdog@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; Sunil Kovvuri Goutham <sgoutham@...vell.com>
> Subject: Re: [EXT] Re: [PATCH 1/2 v7] dt-bindings: watchdog: marvell GTI system
> watchdog driver
> 
> On 09/05/2023 11:01, Bharat Bhushan wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Sent: Tuesday, May 9, 2023 1:38 PM
> >> To: Bharat Bhushan <bbhushan2@...vell.com>; wim@...ux-watchdog.org;
> >> linux@...ck-us.net; robh+dt@...nel.org;
> >> krzysztof.kozlowski+dt@...aro.org;
> >> linux-watchdog@...r.kernel.org; devicetree@...r.kernel.org; linux-
> >> kernel@...r.kernel.org; Sunil Kovvuri Goutham <sgoutham@...vell.com>
> >> Subject: Re: [EXT] Re: [PATCH 1/2 v7] dt-bindings: watchdog: marvell
> >> GTI system watchdog driver
> >>
> >> On 09/05/2023 09:26, Bharat Bhushan wrote:
> >>
> >>
> >>>>> +properties:
> >>>>> +  compatible:
> >>>>> +    oneOf:
> >>>>> +      - const: marvell,octeontx2-wdt
> >>>>
> >>>> Why is this alone? Judging by the enum below, octeontx2 is not specific.
> >>>>
> >>>>> +      - items:
> >>>>> +          - enum:
> >>>>> +              - marvell,octeontx2-95xx-wdt
> >>>>> +              - marvell,octeontx2-96xx-wdt
> >>>>> +              - marvell,octeontx2-98xx-wdt
> >>>>
> >>>> We don't allow wildcards in general
> >>>
> >>> Marvell have octeontx2 series of processor which have watchdog timer.
> >>> In 95xx,98xx,96xx are the processors in octeontx2 series of
> >>> processor. So
> >> octeontx2-95xx is on soc, octeontx2-96xx is another and so on.
> >>
> >> No, 95xx is not a processor. Otherwise please point me to exact
> >> product datasheet. Hint: I checked it.
> >
> > Looks like 95xx data sheet is not public, will remove in that case.
> 
> We can talk about 96xx. Can you point me to the SoC named exactly like this?
> Hint: I checked it.

To recap what Bharat mentioned before along with references to individual processors.
OcteonTx2 is a family of processors
https://www.marvell.com/products/data-processing-units.html
Please check for "OCTEON TX2 DPUs"
CN96xx and CN98xx are two silicon variants in this family.
https://www.marvell.com/content/dam/marvell/en/public-collateral/embedded-processors/marvell-infrastructure-processors-octeon-tx2-cn92xx-cn96xx-cn98xx-product-brief-2020-02.pdf
And CNF95xx is another silicon variant in the same family.
https://www.marvell.com/content/dam/marvell/en/public-collateral/embedded-processors/marvell-infrastructure-processors-octeon-fusion-cnf95xx-product-brief.pdf

Since the HW block is same in all the variants of silicons in this family, we would like to use a
generic string instead of different compatible string for each one. ie
- const: marvell,octeontx2-wdt
Hope this is okay.

Same with CN10K or Octeon10 family of silicons.
https://www.marvell.com/products/data-processing-units.html
Please check for "OCTEON 10"

CN103xx and CN106xx are two silicons in this family.
https://www.marvell.com/content/dam/marvell/en/public-collateral/embedded-processors/marvell-octeon-10-dpu-platform-product-brief.pdf
Same with CNF105xx
https://www.marvell.com/content/dam/marvell/en/public-collateral/embedded-processors/marvell-octeon-10-fusion-cnf105xx-product-brief.pdf

For this family we would like to use
- const: marvell,cn10k-wdt
as the compatible string, as it represents all silicon variants in this family.

Thanks,
Sunil.