linux-kernel - Re: [PATCH] arm64: dts: qcom: sm6350: Move wifi node to correct place

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 May 2023 14:05:13 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Luca Weiss <luca.weiss@...rphone.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm6350: Move wifi node to correct place



On 16.05.2023 08:56, Luca Weiss wrote:
> Somehow wifi was placed further up in the file than where it should be.
> Move it down so the nodes are sorted by reg again.
> 
> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm6350.dtsi | 44 ++++++++++++++++++------------------
>  1 file changed, 22 insertions(+), 22 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> index 18c4616848ce..4dffd7974fa3 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> @@ -1891,28 +1891,6 @@ frame@...2d000 {
>  			};
>  		};
>  
> -		wifi: wifi@...00000 {
> -			compatible = "qcom,wcn3990-wifi";
> -			reg = <0 0x18800000 0 0x800000>;
> -			reg-names = "membase";
> -			memory-region = <&wlan_fw_mem>;
> -			interrupts = <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
> -			iommus = <&apps_smmu 0x20 0x1>;
> -			qcom,msa-fixed-perm;
> -			status = "disabled";
> -		};
> -
>  		apps_rsc: rsc@...00000 {
>  			compatible = "qcom,rpmh-rsc";
>  			label = "apps_rsc";
> @@ -2010,6 +1988,28 @@ cpufreq_hw: cpufreq@...23000 {
>  			#freq-domain-cells = <1>;
>  			#clock-cells = <1>;
>  		};
> +
> +		wifi: wifi@...00000 {
> +			compatible = "qcom,wcn3990-wifi";
> +			reg = <0 0x18800000 0 0x800000>;
> +			reg-names = "membase";
> +			memory-region = <&wlan_fw_mem>;
> +			interrupts = <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
> +			iommus = <&apps_smmu 0x20 0x1>;
> +			qcom,msa-fixed-perm;
> +			status = "disabled";
> +		};
>  	};
>  
>  	timer {
> 
> ---
> base-commit: f1fcbaa18b28dec10281551dfe6ed3a3ed80e3d6
> change-id: 20230516-sm6350-order-f9a836dc7247
> 
> Best regards,