linux-kernel - Re: [PATCH net] net: dsa: mv88e6xxx: Fix mv88e6393x EPC write command offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a51da03-30b9-41d0-ac14-ec29573afd61@lunn.ch>
Date:   Tue, 16 May 2023 14:18:21 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Marco Migliore <m.migliore@...sse.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Ashkan Boldaji <ashkan.boldaji@...i.com>,
        Pavana Sharma <pavana.sharma@...i.com>,
        Marek Behún <kabel@...nel.org>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Fix mv88e6393x EPC write
 command offset

On Tue, May 16, 2023 at 09:38:54AM +0200, Marco Migliore wrote:
> According to datasheet, the command opcode must be specified
> into bits [14:12] of the Extended Port Control register (EPC).
> 
> Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family")
> Signed-off-by: Marco Migliore <m.migliore@...sse.com>

Hi Marco

Thanks for the respin.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

For the next time you submit a patch, it is normal to put a version in the Subject line:

[PATCH net v2] net: dsa: mv88e6xxx: Fix mv88e6393x EPC write command offset

That helps us keep track of the versions, and makes it clear which is
the latest version.

    Andrew