linux-kernel - Re: [PATCH 10/14] suspend: add a arch_resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6b7f6f66-7890-47a3-a22d-e29f2944823a@app.fastmail.com>
Date:   Wed, 17 May 2023 16:52:01 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Rafael J . Wysocki" <rafael@...nel.org>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Andrew Morton" <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        "Russell King" <linux@...linux.org.uk>,
        "Catalin Marinas" <catalin.marinas@....com>,
        "Will Deacon" <will@...nel.org>, "Michal Simek" <monstr@...str.eu>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        "Helge Deller" <deller@....de>,
        "Michael Ellerman" <mpe@...erman.id.au>,
        "Palmer Dabbelt" <palmer@...belt.com>,
        "Heiko Carstens" <hca@...ux.ibm.com>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Ingo Molnar" <mingo@...hat.com>, x86@...nel.org,
        "Paul Moore" <paul@...l-moore.com>,
        "Eric Paris" <eparis@...hat.com>,
        "Dennis Zhou" <dennis@...nel.org>, "Tejun Heo" <tj@...nel.org>,
        "Christoph Lameter" <cl@...ux.com>, "Pavel Machek" <pavel@....cz>,
        "Peter Zijlstra" <peterz@...radead.org>,
        "Waiman Long" <longman@...hat.com>,
        "Boqun Feng" <boqun.feng@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
        linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
        audit@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com
Subject: Re: [PATCH 10/14] suspend: add a arch_resume_nosmt() prototype

On Wed, May 17, 2023, at 15:48, Rafael J. Wysocki wrote:
> On Wed, May 17, 2023 at 3:12 PM Arnd Bergmann <arnd@...nel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> The arch_resume_nosmt() has a __weak definition, plus an x86
>> specific override, but no prototype that ensures the two have
>> the same arguments. This causes a W=1 warning:
>>
>> arch/x86/power/hibernate.c:189:5: error: no previous prototype for 'arch_resume_nosmt' [-Werror=missing-prototypes]
>>
>> Add the prototype in linux/suspend.h, which is included in
>> both places.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Do you want me to pick this up?

Yes, please do. Thanks,

     Arnd