linux-kernel - Re: [PATCH 2/2] ALSA: oss: avoid missing-prototype warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h6sb0zwl.wl-tiwai@suse.de>
Date:   Wed, 17 May 2023 16:56:58 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Arnd Bergmann <arnd@...db.de>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ALSA: oss: avoid missing-prototype warnings

On Tue, 16 May 2023 21:50:42 +0200,
Arnd Bergmann wrote:
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> Two functions are defined and used in pcm_oss.c but also optionally
> used from io.c, with an optional prototype. If CONFIG_SND_PCM_OSS_PLUGINS
> is disabled, this causes a warning as the functions are not static
> and have no prototype:
> 
> sound/core/oss/pcm_oss.c:1235:19: error: no previous prototype for 'snd_pcm_oss_write3' [-Werror=missing-prototypes]
> sound/core/oss/pcm_oss.c:1266:19: error: no previous prototype for 'snd_pcm_oss_read3' [-Werror=missing-prototypes]
> 
> Avoid this by making the prototypes unconditional.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, applied now.


Takashi