linux-kernel - [PATCH v4 0/3] cpufreq/amd-pstate: Fix null pointer dereference when frequency invariance is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230517162817.8538-1-wyes.karny@amd.com>
Date:   Wed, 17 May 2023 16:28:14 +0000
From:   Wyes Karny <wyes.karny@....com>
To:     <ray.huang@....com>, <rafael@...nel.org>, <viresh.kumar@...aro.org>
CC:     <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <gautham.shenoy@....com>, Wyes Karny <wyes.karny@....com>
Subject: [PATCH v4 0/3] cpufreq/amd-pstate: Fix null pointer dereference when frequency invariance is disabled

Currently, amd_pstate only uses `adjust_perf` and `target` callback
functions to get the frequency/effective utilization data from scaling
governors. But the governor can switch back to fast_switch (as
fast_switch_possible is set) when frequency invariance is disabled. In
that case, if the driver didn't set fast_switch function pointer, null
pointer dereference can happen and the kernel will crash.

Currently, frequency invariance is turned off when any anomaly is
detected with aperf/mperf readings. Which triggers this problem.

Fix this by adding `fast_switch` function in the amd_pstate driver.

The same problem could arise with any scaling driver which doesn't set
fast_switch but sets fast_switch_possible.  Return failure while loading
such drivers.

Changelog:
v3 -> v4:
- Add extra patch to remove fast_switch_possible flag from amd_pstate
  active mode driver.
- Fail to load such drivers which sets fast_switch_possible flag but not
  fast_switch.

v2 -> v3
- Add fast_switch callback in amd_pstate and warn if any driver
  sets fast_swich_possible flag but not fast_switch function pointer.

v1 -> v2
- Remove fast_switch_enabled flag dependency for adjust_perf callback

v1: https://lore.kernel.org/linux-pm/20230410095045.14872-1-wyes.karny@amd.com/
v2: https://lore.kernel.org/linux-pm/20230509180503.739208-1-wyes.karny@amd.com/
v3: https://lore.kernel.org/lkml/20230515113404.4259-1-wyes.karny@amd.com/

Gautham R. Shenoy (1):
  amd_pstate: Add ->fast_switch() callback

Wyes Karny (2):
  cpufreq/amd-pstate: Remove fast_switch_possible flag from active
    driver
  cpufreq: Return failure if fast_switch is not set and
    fast_switch_possible is set

 drivers/cpufreq/amd-pstate.c | 38 ++++++++++++++++++++++++++++--------
 drivers/cpufreq/cpufreq.c    |  5 +++++
 include/linux/cpufreq.h      |  4 +++-
 3 files changed, 38 insertions(+), 9 deletions(-)

-- 
2.34.1