lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 18 May 2023 01:46:13 +0800
From:   kernel test robot <lkp@...el.com>
To:     Boerge Struempfel <boerge.struempfel@...il.com>
Cc:     oe-kbuild-all@...ts.linux.dev, boerge.struempfel@...il.com,
        bstruempfel@...ratronik.de, andy.shevchenko@...il.com,
        festevam@...il.com, amit.kumar-mahapatra@....com,
        broonie@...nel.org, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] spi: spi-imx: add support for SPI_MOSI_IDLE_LOW mode
 bit

Hi Boerge,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-spi/for-next]
[also build test ERROR on shawnguo/for-next linus/master v6.4-rc2 next-20230517]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Boerge-Struempfel/spi-spi-imx-add-support-for-SPI_MOSI_IDLE_LOW-mode-bit/20230517-183245
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link:    https://lore.kernel.org/r/20230517103007.26287-2-boerge.struempfel%40gmail.com
patch subject: [PATCH 2/3] spi: spi-imx: add support for SPI_MOSI_IDLE_LOW mode bit
config: m68k-allyesconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/62dc97266153cfe514c983e9baeb51766f16daa2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Boerge-Struempfel/spi-spi-imx-add-support-for-SPI_MOSI_IDLE_LOW-mode-bit/20230517-183245
        git checkout 62dc97266153cfe514c983e9baeb51766f16daa2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/spi/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305180132.mcBZduH0-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/spi/spi-imx.c: In function 'mx51_ecspi_prepare_message':
>> drivers/spi/spi-imx.c:1956:39: error: unterminated argument list invoking macro "MX51_ECSPI_CONFIG_DATACTL"
    1956 | MODULE_ALIAS("platform:" DRIVER_NAME);
         |                                       ^
>> drivers/spi/spi-imx.c:580:25: error: 'MX51_ECSPI_CONFIG_DATACTL' undeclared (first use in this function)
     580 |                 cfg &= ~MX51_ECSPI_CONFIG_DATACTL(spi_get_chipselect(spi, 0);
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:580:25: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/spi/spi-imx.c:580:50: error: expected ';' at end of input
     580 |                 cfg &= ~MX51_ECSPI_CONFIG_DATACTL(spi_get_chipselect(spi, 0);
         |                                                  ^
         |                                                  ;
   ......
   drivers/spi/spi-imx.c:579:9: note: '-Wmisleading-indentation' is disabled from this point onwards, since column-tracking was disabled due to the size of the code/headers
     579 |         else
         |         ^~~~
   drivers/spi/spi-imx.c:579:9: note: adding '-flarge-source-files' will allow for more column-tracking support, at the expense of compilation time and memory
>> drivers/spi/spi-imx.c:580:17: error: expected declaration or statement at end of input
     580 |                 cfg &= ~MX51_ECSPI_CONFIG_DATACTL(spi_get_chipselect(spi, 0);
         |                 ^~~
   drivers/spi/spi-imx.c:529:13: warning: unused variable 'current_cfg' [-Wunused-variable]
     529 |         u32 current_cfg = cfg;
         |             ^~~~~~~~~~~
   drivers/spi/spi-imx.c:527:22: warning: unused variable 'delay' [-Wunused-variable]
     527 |         u32 testreg, delay;
         |                      ^~~~~
   drivers/spi/spi-imx.c:526:13: warning: unused variable 'min_speed_hz' [-Wunused-variable]
     526 |         u32 min_speed_hz = ~0U;
         |             ^~~~~~~~~~~~
   drivers/spi/spi-imx.c:524:30: warning: unused variable 'xfer' [-Wunused-variable]
     524 |         struct spi_transfer *xfer;
         |                              ^~~~
   drivers/spi/spi-imx.c:580:17: error: no return statement in function returning non-void [-Werror=return-type]
     580 |                 cfg &= ~MX51_ECSPI_CONFIG_DATACTL(spi_get_chipselect(spi, 0);
         |                 ^~~
   drivers/spi/spi-imx.c: At top level:
   drivers/spi/spi-imx.c:520:12: warning: 'mx51_ecspi_prepare_message' defined but not used [-Wunused-function]
     520 | static int mx51_ecspi_prepare_message(struct spi_imx_data *spi_imx,
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:511:13: warning: 'mx51_ecspi_disable' defined but not used [-Wunused-function]
     511 | static void mx51_ecspi_disable(struct spi_imx_data *spi_imx)
         |             ^~~~~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:502:13: warning: 'mx51_ecspi_trigger' defined but not used [-Wunused-function]
     502 | static void mx51_ecspi_trigger(struct spi_imx_data *spi_imx)
         |             ^~~~~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:486:13: warning: 'mx51_ecspi_intctrl' defined but not used [-Wunused-function]
     486 | static void mx51_ecspi_intctrl(struct spi_imx_data *spi_imx, int enable)
         |             ^~~~~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:449:21: warning: 'mx51_ecspi_clkdiv' defined but not used [-Wunused-function]
     449 | static unsigned int mx51_ecspi_clkdiv(struct spi_imx_data *spi_imx,
         |                     ^~~~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:428:13: warning: 'mx53_ecspi_tx_slave' defined but not used [-Wunused-function]
     428 | static void mx53_ecspi_tx_slave(struct spi_imx_data *spi_imx)
         |             ^~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:408:13: warning: 'mx53_ecspi_rx_slave' defined but not used [-Wunused-function]
     408 | static void mx53_ecspi_rx_slave(struct spi_imx_data *spi_imx)
         |             ^~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:380:13: warning: 'spi_imx_buf_tx_swap' defined but not used [-Wunused-function]
     380 | static void spi_imx_buf_tx_swap(struct spi_imx_data *spi_imx)
         |             ^~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:328:13: warning: 'spi_imx_buf_rx_swap' defined but not used [-Wunused-function]
     328 | static void spi_imx_buf_rx_swap(struct spi_imx_data *spi_imx)
         |             ^~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:233:13: warning: 'spi_imx_can_dma' defined but not used [-Wunused-function]
     233 | static bool spi_imx_can_dma(struct spi_controller *controller, struct spi_device *spi,
         |             ^~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:207:21: warning: 'spi_imx_clkdiv_2' defined but not used [-Wunused-function]
     207 | static unsigned int spi_imx_clkdiv_2(unsigned int fin,
         |                     ^~~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:193:21: warning: 'spi_imx_clkdiv_1' defined but not used [-Wunused-function]
     193 | static unsigned int spi_imx_clkdiv_1(unsigned int fin,
         |                     ^~~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:165:13: warning: 'spi_imx_buf_tx_u32' defined but not used [-Wunused-function]
     165 | static void spi_imx_buf_tx_##type(struct spi_imx_data *spi_imx)         \
         |             ^~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:184:1: note: in expansion of macro 'MXC_SPI_BUF_TX'
     184 | MXC_SPI_BUF_TX(u32)
         | ^~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:152:13: warning: 'spi_imx_buf_rx_u32' defined but not used [-Wunused-function]
     152 | static void spi_imx_buf_rx_##type(struct spi_imx_data *spi_imx)         \
         |             ^~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:183:1: note: in expansion of macro 'MXC_SPI_BUF_RX'
     183 | MXC_SPI_BUF_RX(u32)
         | ^~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:165:13: warning: 'spi_imx_buf_tx_u8' defined but not used [-Wunused-function]
     165 | static void spi_imx_buf_tx_##type(struct spi_imx_data *spi_imx)         \
         |             ^~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:180:1: note: in expansion of macro 'MXC_SPI_BUF_TX'
     180 | MXC_SPI_BUF_TX(u8)
         | ^~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:152:13: warning: 'spi_imx_buf_rx_u8' defined but not used [-Wunused-function]
     152 | static void spi_imx_buf_rx_##type(struct spi_imx_data *spi_imx)         \
         |             ^~~~~~~~~~~~~~~
   drivers/spi/spi-imx.c:179:1: note: in expansion of macro 'MXC_SPI_BUF_RX'
     179 | MXC_SPI_BUF_RX(u8)
         | ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/MX51_ECSPI_CONFIG_DATACTL +1956 drivers/spi/spi-imx.c

b5f3294f0be549 drivers/spi/mxc_spi.c Sascha Hauer  2009-09-22  1952  
92bad4a4c755cd drivers/spi/spi-imx.c Fabio Estevam 2021-03-16  1953  MODULE_DESCRIPTION("i.MX SPI Controller driver");
b5f3294f0be549 drivers/spi/mxc_spi.c Sascha Hauer  2009-09-22  1954  MODULE_AUTHOR("Sascha Hauer, Pengutronix");
b5f3294f0be549 drivers/spi/mxc_spi.c Sascha Hauer  2009-09-22  1955  MODULE_LICENSE("GPL");
3133fba3bb3a37 drivers/spi/spi-imx.c Fabio Estevam 2013-01-07 @1956  MODULE_ALIAS("platform:" DRIVER_NAME);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "config" of type "text/plain" (289819 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ