linux-kernel - Re: [PATCH] media: c8sectpfe: convert to gpio descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGUnBfqBLWkD7ZgD@google.com>
Date:   Wed, 17 May 2023 12:12:05 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Sakari Ailus <sakari.ailus@....fi>
Cc:     Arnd Bergmann <arnd@...nel.org>,
        Patrice Chotard <patrice.chotard@...s.st.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Hugues Fruchet <hugues.fruchet@...com>,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: c8sectpfe: convert to gpio descriptors

On Wed, May 17, 2023 at 09:21:00PM +0300, Sakari Ailus wrote:
> Hi Arnd,
> 
> On Mon, Jan 30, 2023 at 02:09:47PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > The gpio usage in the function is fairly straightforward,
> > but the normal gpiod_get() interface cannot be used here
> > since the gpio is referenced by a child node of the device.
> > 
> > Using devm_fwnode_gpiod_get_index() is the best alternative
> > here.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> I've picked
> <URL:https://patchwork.linuxtv.org/project/linux-media/patch/20230130131003.668888-1-arnd@kernel.org/>
> instead. I hope that's fine. Also cc Dmitry.

What do you mean "instead"? This is the exact patch that started this
thread, and it is broken (uses wrong name of the GPIO and wrong polarity).

I'd much rather you picked up
https://lore.kernel.org/all/Y92VLGLQJZ%2FUDRx1@google.com/

Thanks.

-- 
Dmitry