linux-kernel - Re: [PATCH 2/2] usb: typec: ucsi: Don't create power supplies for dGPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGUneSmV6dJBk7AO@smile.fi.intel.com>
Date:   Wed, 17 May 2023 22:14:01 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Greg KH <greg@...ah.com>
Cc:     Mario Limonciello <mario.limonciello@....com>,
        heikki.krogerus@...ux.intel.com, rafael@...nel.org,
        ajayg@...dia.com, linux-i2c@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, Evan.Quan@....com, Lijo.Lazar@....com,
        Sanket.Goswami@....com
Subject: Re: [PATCH 2/2] usb: typec: ucsi: Don't create power supplies for
 dGPUs

On Wed, May 17, 2023 at 08:58:49PM +0200, Greg KH wrote:
> On Wed, May 17, 2023 at 08:14:13PM +0300, Andy Shevchenko wrote:
> > On Tue, May 16, 2023 at 01:25:41PM -0500, Mario Limonciello wrote:

...

> > > +static const struct property_entry dgpu_properties[] = {
> > > +	/* USB-C doesn't power the system */
> > > +	PROPERTY_ENTRY_U8("scope", POWER_SUPPLY_SCOPE_DEVICE),
> > > +	{},
> > 
> > Comma is not needed in terminator entry.
> 
> But it's encouraged!

Why?! This might lead to the subtle mistakes going unnoticed during rebases.
Yes, it's quite unlikely, but it might be still possible to have the empty
entry in the middle of the array. Why should we shoot ourselves in the foot
if we can avoid it without any effort?

Hence I can say it's discouraged.

-- 
With Best Regards,
Andy Shevchenko