[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230517195911.GG271152@darkstar.musicnaut.iki.fi>
Date: Wed, 17 May 2023 22:59:11 +0300
From: Aaro Koskinen <aaro.koskinen@....fi>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Janusz Krzysztofik <jmkrzyszt@...il.com>,
Tony Lindgren <tony@...mide.com>,
Russell King <linux@...linux.org.uk>,
Daniel Mack <daniel@...que.org>,
Haojian Zhuang <haojian.zhuang@...il.com>,
Robert Jarzmik <robert.jarzmik@...e.fr>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Mark Brown <broonie@...nel.org>,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
Andreas Kemnade <andreas@...nade.info>,
Helge Deller <deller@....de>,
Ulf Hansson <ulf.hansson@...aro.org>,
linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
linux-input@...r.kernel.org, linux-spi@...r.kernel.org,
linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-mmc@...r.kernel.org
Subject: Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes
Hi,
This does not compile as nokia770_ads7846_props is declared twice,
and nokia770_cbus_props and nokia770_mpuio_gpiochip_swnode are missing.
On Mon, May 08, 2023 at 11:20:06PM +0200, Linus Walleij wrote:
> +static const struct software_node_ref_args nokia770_cbus_gpio_refs[] = {
> + SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 9, 0),
> + SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 10, 0),
> + SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 11, 0),
> +};
These should be nokia770_mpuio_gpiochip_node.
> +static const struct property_entry nokia770_ads7846_props[] = {
> + PROPERTY_ENTRY_REF_ARRAY("gpios", nokia770_cbus_gpio_refs),
> + { }
> };
This should be nokia770_cbus_props.
A.
Powered by blists - more mailing lists