linux-kernel - Re: [PATCH v4 1/3] spi: add SPI_MOSI_IDLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5CJwwKmDYRxnny2JOrwucGn=q7+9xKqk_NSvZ_wyNSHEQ@mail.gmail.com>
Date:   Wed, 17 May 2023 20:52:56 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Börge Strümpfel <boerge.struempfel@...il.com>
Cc:     bstruempfel@...ratronik.de, andy.shevchenko@...il.com,
        amit.kumar-mahapatra@....com, broonie@...nel.org,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] spi: add SPI_MOSI_IDLE_LOW mode bit

On Wed, May 17, 2023 at 8:20 PM Börge Strümpfel
<boerge.struempfel@...il.com> wrote:

> My bad. Thanks for letting me know. Just to clarify: I put the
> changelog directly below
> the first ---? And do I then put another --- between the changelog and
> the following
> include/uapi/linux/spi/spi.h | 3 ++- line?  or is there just a
> new-line seperating them.

It should look like this:

Commit log line 1
Commit log line 2
...
Commit log line n

Signed-off-by: Your name <your@...il.com>
---
Changes since v3:
- Bla bla bla

> And if you don't mind my trivial questions, am I supposed to write a
> cover letter for
> the patch-stack? I seem to find contradictory answers to this question online.

Yes, for a patch series having a cover letter is helpful.

> > Should tools/spi/spidev_test.c be changed to include this new
> > mosi-idle-low option?
>
> Until now I actually wasn't aware of this tool. However on first
> glance, it seems
> reasonable to add this mode bit. I can certainly add this mode bit to
> the spidev_test
> if desired.

Yes, that would be great.

> While looking through the code, I noticed, that the latest two
> additions to the spi->mode
> (SPI_3WIRE_HIZ and SPI_RX_CPHA_FLIP) are also missing from this tool. Is this
> by design, or should they then be included as well?

Looks like these two are missing and would be good to get them included as well.