linux-kernel - Re: [PATCH] iommu/amd: Fix domain flush size when syncing iotlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71A3F44C-B684-4946-AF11-3DB98E3AC641@vmware.com>
Date:   Wed, 17 May 2023 05:58:43 +0000
From:   Nadav Amit <namit@...are.com>
To:     Jon Pan-Doh <pandoh@...gle.com>
CC:     Joerg Roedel <joro@...tes.org>,
        Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
        Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sudheer Dantuluri <dantuluris@...gle.com>,
        Gary Zibrat <gzibrat@...gle.com>
Subject: Re: [PATCH] iommu/amd: Fix domain flush size when syncing iotlb


> On May 16, 2023, at 10:49 PM, Jon Pan-Doh <pandoh@...gle.com> wrote:
> 
> !! External Email
> 
> On Wed, Apr 26, 2023 at 1:32 PM Jon Pan-Doh <pandoh@...gle.com> wrote:
>> 
>> When running on an AMD vIOMMU, we observed multiple invalidations (of
>> decreasing power of 2 aligned sizes) when unmapping a single page.
>> 
>> Domain flush takes gather bounds (end-start) as size param. However,
>> gather->end is defined as the last inclusive address (start + size - 1).
>> This leads to an off by 1 error.
>> 
>> With this patch, verified that 1 invalidation occurs when unmapping a
>> single page.
>> 
>> Fixes: a270be1b3fdf ("iommu/amd: Use only natural aligned flushes in a VM")
>> Signed-off-by: Jon Pan-Doh <pandoh@...gle.com>
>> Tested-by: Sudheer Dantuluri <dantuluris@...gle.com>
>> Suggested-by: Gary Zibrat <gzibrat@...gle.com>
> 
> Cc: stable@...r.kernel.org

Assuming the patch was still not applied, I think that Greg KH would
prefer that you send v2 that includes the “Cc: <stable@...r.kernel.org>”
(notice the “<“ and “>" signs) and ideally the version in which I added
the buggy code (sorry for that again) after a “#” sign.

I think it is version 5.15.

IOW: If the patch was still not applied by Joerg, please send v2 with:

Cc: <stable@...r.kernel.org <mailto:stable@...r.kernel.org>> # 5.15.x

In the commit log.