linux-kernel - Re: [PATCH wireless v2] wifi: rtw88: sdio: Always use two consecutive bytes for word operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <168430378778.24096.6636792783589733385.kvalo@kernel.org>
Date:   Wed, 17 May 2023 06:09:53 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        pkshih@...ltek.com, tony0620emma@...il.com,
        jernej.skrabec@...il.com, linux-sunxi@...ts.linux.dev,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Rudi Heitbaum <rudi@...tbaum.com>
Subject: Re: [PATCH wireless v2] wifi: rtw88: sdio: Always use two consecutive
 bytes for word operations

Martin Blumenstingl <martin.blumenstingl@...glemail.com> wrote:

> The Allwinner sunxi-mmc controller cannot handle word (16 bit)
> transfers. So and sdio_{read,write}w fails with messages like the
> following example using an RTL8822BS (but the same problems were also
> observed with RTL8822CS and RTL8723DS chips):
>   rtw_8822bs mmc1:0001:1: Firmware version 27.2.0, H2C version 13
>   sunxi-mmc 4021000.mmc: unaligned scatterlist: os f80 length 2
>   sunxi-mmc 4021000.mmc: map DMA failed
>   rtw_8822bs mmc1:0001:1: sdio read16 failed (0x10230): -22
> 
> Use two consecutive single byte accesses for word operations instead. It
> turns out that upon closer inspection this is also what the vendor
> driver does, even though it does have support for sdio_{read,write}w. So
> we can conclude that the rtw88 chips do support word access but only on
> SDIO controllers that also support it. Since there's no way to detect if
> the controller supports word access or not the rtw88 sdio driver
> switches to the easiest approach: avoiding word access.
> 
> Reported-by: Larry Finger <Larry.Finger@...inger.net>
> Closes: https://lore.kernel.org/linux-wireless/527585e5-9cdd-66ed-c3af-6da162f4b720@lwfinger.net/
> Reported-by: Rudi Heitbaum <rudi@...tbaum.com>
> Link: https://github.com/LibreELEC/LibreELEC.tv/pull/7837#issue-1708469467
> Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
> Reviewed-by: Ping-Ke Shih <pkshih@...ltek.com>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

Patch applied to wireless.git, thanks.

cb0ddaaa5db0 wifi: rtw88: sdio: Always use two consecutive bytes for word operations

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230515195043.572375-1-martin.blumenstingl@googlemail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches