linux-kernel - Re: [PATCH] regmap: Account for register length when chunking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGQqzlU7XPF+rS8c@finisterre.sirena.org.uk>
Date:   Wed, 17 May 2023 10:15:58 +0900
From:   Mark Brown <broonie@...nel.org>
To:     Jim Wylder <jwylder@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: Account for register length when chunking

On Tue, May 16, 2023 at 10:52:23AM -0500, Jim Wylder wrote:

> +	size_t max_data = map->max_raw_write - map->format.reg_bytes;

This still doesn't take account of padding bytes.

Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed.  Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing.  If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)