linux-kernel - Re: [PATCH] mm/hugetlb: remove hugetlb_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 May 2023 09:20:14 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Sidhartha Kumar <sidhartha.kumar@...cle.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Cc:     akpm@...ux-foundation.org, songmuchun@...edance.com,
        mike.kravetz@...cle.com, willy@...radead.org
Subject: Re: [PATCH] mm/hugetlb: remove hugetlb_page_subpool()

On 17.05.23 00:52, Sidhartha Kumar wrote:
> All users of hugetlb_page_subpool() have been converted to use the folio
> equivalent. This function can be safely removed.
> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>
> ---
>   include/linux/hugetlb.h | 13 -------------
>   1 file changed, 13 deletions(-)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index b2b698f9a2ecb..21f942025fecd 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -755,14 +755,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
>   	return folio->_hugetlb_subpool;
>   }
>   
> -/*
> - * hugetlb page subpool pointer located in hpage[2].hugetlb_subpool
> - */
> -static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
> -{
> -	return hugetlb_folio_subpool(page_folio(hpage));
> -}
> -
>   static inline void hugetlb_set_folio_subpool(struct folio *folio,
>   					struct hugepage_subpool *subpool)
>   {
> @@ -1029,11 +1021,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
>   	return NULL;
>   }
>   
> -static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
> -{
> -	return NULL;
> -}
> -
>   static inline int isolate_or_dissolve_huge_page(struct page *page,
>   						struct list_head *list)
>   {


Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb