linux-kernel - Re: [PATCH] EDAC: Expose node link in sysfs if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <723b9f11-d427-6c5d-5d99-969550244129@gmail.com>
Date:   Wed, 17 May 2023 14:43:30 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Yajun Deng <yajun.deng@...ux.dev>, bp@...en8.de,
        tony.luck@...el.com, james.morse@....com, mchehab@...nel.org,
        rric@...nel.org, corbet@....net
Cc:     linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH] EDAC: Expose node link in sysfs if CONFIG_NUMA

On 5/16/23 15:07, Yajun Deng wrote:
> +
> +What:		/sys/devices/system/edac/mc/mc*/node*
> +Date:		May 2023
> +Contact:	Yajun Deng <yajun.deng@...ux.dev>
> +		linux-edac@...r.kernel.org
> +Description:	When CONFIG_NUMA is enabled, a symbolic link that points to the
> +		corresponding NUMA node directory.
> +
> +		For example, the following symbolic link is created for node0 on mc0
> +		and mc1:
> +

"For example, on node0 with two memory control directories mc0 and mc1
the symlinks are::" (I prefer using literal code block here).

> +		/sys/devices/system/edac/mc/mc0/node0 -> ../../../node/node0
> +		/sys/devices/system/edac/mc/mc1/node0 -> ../../../node/node0

Or bullet lists should better fit listing above?

> +
> +What:		/sys/devices/system/node/node*/mc*
> +Date:		May 2023
> +Contact:	Yajun Deng <yajun.deng@...ux.dev>
> +		linux-edac@...r.kernel.org
> +Description:	When CONFIG_NUMA is enabled, a symbolic link that points to the
> +		corresponding memory control directory.
> +
> +		For example, the following symbolic link is created for mc0 and mc1
> +		on node0:
> +
> +		/sys/devices/system/node/node0/mc0 -> ../../edac/mc/mc0
> +		/sys/devices/system/node/node0/mc1 -> ../../edac/mc/mc1

Similar as my review above.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara