linux-kernel - Re: [PATCH] gpio: mockup: Fix mode of debugfs files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MfuFJu=AJu6=3S64TvYwAY2enUafqCFat-j9G8O58UM4A@mail.gmail.com>
Date:   Wed, 17 May 2023 11:19:53 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Zev Weiss <zev@...ilderbeest.net>
Cc:     Bamvor Jian Zhang <bamv2005@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...nel.org
Subject: Re: [PATCH] gpio: mockup: Fix mode of debugfs files

On Wed, May 17, 2023 at 7:50 AM Zev Weiss <zev@...ilderbeest.net> wrote:
>
> This driver's debugfs files have had a read operation since commit
> 2a9e27408e12 ("gpio: mockup: rework debugfs interface"), but were
> still being created with write-only mode bits.  Update them to
> indicate that the files can also be read.
>
> Signed-off-by: Zev Weiss <zev@...ilderbeest.net>
> Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface")
> Cc: stable@...nel.org # v5.1+
> ---
>  drivers/gpio/gpio-mockup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
> index e6a7049bef64..b32063ac845a 100644
> --- a/drivers/gpio/gpio-mockup.c
> +++ b/drivers/gpio/gpio-mockup.c
> @@ -369,7 +369,7 @@ static void gpio_mockup_debugfs_setup(struct device *dev,
>                 priv->offset = i;
>                 priv->desc = gpiochip_get_desc(gc, i);
>
> -               debugfs_create_file(name, 0200, chip->dbg_dir, priv,
> +               debugfs_create_file(name, 0600, chip->dbg_dir, priv,
>                                     &gpio_mockup_debugfs_ops);
>         }
>  }
> --
> 2.40.1
>

Good catch, applied, thanks!

Bart