linux-kernel - Re: [PATCH] gpio: sa1100: include <mach/generic.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 May 2023 11:51:23 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Bartosz Golaszewski" <brgl@...ev.pl>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Linus Walleij" <linus.walleij@...aro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: sa1100: include <mach/generic.h>

On Wed, May 17, 2023, at 11:33, Bartosz Golaszewski wrote:
> On Tue, May 16, 2023 at 10:16 PM Arnd Bergmann <arnd@...nel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> sa1100_init_gpio() is declared in a machine specific header so it
>> can be called from platform code, but the definition is in the device
>> driver, which causes a warning:
>>
>> drivers/gpio/gpio-sa1100.c:310:13: error: no previous prototype for 'sa1100_init_gpio' [-Werror=missing-prototypes]
>>
>> It's already possible to include mach/generic.h from drivers, so add
>> this one here as well.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>  drivers/gpio/gpio-sa1100.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpio/gpio-sa1100.c b/drivers/gpio/gpio-sa1100.c
>> index 342a59ea489a..3b1cc8462fcb 100644
>> --- a/drivers/gpio/gpio-sa1100.c
>> +++ b/drivers/gpio/gpio-sa1100.c
>> @@ -13,6 +13,7 @@
>>  #include <mach/hardware.h>
>>  #include <mach/regs-gpio.h>
>
> This doesn't apply on top of my branch (neither on next) because of
> this line. I can't see where this was added. Any hint?

My mistake, my working tree had some experimental patches in it.

I'll send a v2.

    Arnd