linux-kernel - Re: [RESEND PATCH v7 2/2] EDAC/qcom: Get rid of hardcoded register offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230517103815.GCZGSul9wCk4K8/XkN@fat_crate.local>
Date:   Wed, 17 May 2023 12:38:15 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     andersson@...nel.org, mchehab@...nel.org, james.morse@....com,
        rric@...nel.org, linux-arm-msm@...r.kernel.org,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        dmitry.baryshkov@...aro.org, stable@...r.kernel.org
Subject: Re: [RESEND PATCH v7 2/2] EDAC/qcom: Get rid of hardcoded register
 offsets

On Wed, May 17, 2023 at 11:58:59AM +0530, Manivannan Sadhasivam wrote:
> The LLCC EDAC register offsets varies between each SoC. Hardcoding the
> register offsets won't work and will often result in crash due to
> accessing the wrong locations.
> 
> Hence, get the register offsets from the LLCC driver matching the
> individual SoCs.
> 
> Cc: <stable@...r.kernel.org> # 6.0: 5365cea199c7 ("soc: qcom: llcc: Rename reg_offset structs to reflect LLCC version")
> Cc: <stable@...r.kernel.org> # 6.0: c13d7d261e36 ("soc: qcom: llcc: Pass LLCC version based register offsets to EDAC driver")
> Cc: <stable@...r.kernel.org> # 6.0
> Fixes: a6e9d7ef252c ("soc: qcom: llcc: Add configuration data for SM8450 SoC")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---
>  drivers/edac/qcom_edac.c           | 116 ++++++++++++++---------------
>  include/linux/soc/qcom/llcc-qcom.h |   6 --
>  2 files changed, 58 insertions(+), 64 deletions(-)

In case Bjorn wants to pick this up:

Acked-by: Borislav Petkov (AMD) <bp@...en8.de>

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette