lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 17 May 2023 14:57:14 +0100
From:   Tudor Ambarus <tudor.ambarus@...aro.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        David Woodhouse <dwmw2@...radead.org>,
        Richard Weinberger <richard@....at>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jffs2: mark __jffs2_dbg_superblock_counts() static



On 5/17/23 14:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This function is only called locally and does not need to be
> global. Since there is no external prototype, gcc warns about
> the non-static definition:
> 
> fs/jffs2/debug.c:160:6: error: no previous prototype for '__jffs2_dbg_superblock_counts' [-Werror=missing-prototypes]
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org>

> ---
>  fs/jffs2/debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jffs2/debug.c b/fs/jffs2/debug.c
> index 9d26b1b9fc01..0925caab23c4 100644
> --- a/fs/jffs2/debug.c
> +++ b/fs/jffs2/debug.c
> @@ -157,7 +157,7 @@ __jffs2_dbg_prewrite_paranoia_check(struct jffs2_sb_info *c,
>  	kfree(buf);
>  }
>  
> -void __jffs2_dbg_superblock_counts(struct jffs2_sb_info *c)
> +static void __jffs2_dbg_superblock_counts(struct jffs2_sb_info *c)
>  {
>  	struct jffs2_eraseblock *jeb;
>  	uint32_t free = 0, dirty = 0, used = 0, wasted = 0,

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ