linux-kernel - Re: [PATCH RESEND] sched/nohz: Add HRTICK_BW for using cfs bandwidth with nohz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 May 2023 02:43:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     Phil Auld <pauld@...hat.com>, linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Juri Lelli <juri.lelli@...hat.com>,
        Ingo Molnar <mingo@...hat.com>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Valentin Schneider <vschneid@...hat.com>,
        Ben Segall <bsegall@...gle.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mel Gorman <mgorman@...e.de>, Phil Auld <pauld@...hat.com>
Subject: Re: [PATCH RESEND] sched/nohz: Add HRTICK_BW for using cfs bandwidth
 with nohz_full

Hi Phil,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/master tip/auto-latest linus/master v6.4-rc2 next-20230518]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Phil-Auld/sched-nohz-Add-HRTICK_BW-for-using-cfs-bandwidth-with-nohz_full/20230518-215053
base:   tip/sched/core
patch link:    https://lore.kernel.org/r/20230518132038.3534728-1-pauld%40redhat.com
patch subject: [PATCH RESEND] sched/nohz: Add HRTICK_BW for using cfs bandwidth with nohz_full
config: i386-randconfig-a002
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/525e4d701ca23f8041908b074be2c82b58a28230
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Phil-Auld/sched-nohz-Add-HRTICK_BW-for-using-cfs-bandwidth-with-nohz_full/20230518-215053
        git checkout 525e4d701ca23f8041908b074be2c82b58a28230
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305190244.Fmsml97o-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/sched/fair.c:8117:3: error: implicit declaration of function 'start_hrtick_cfs_bw' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   start_hrtick_cfs_bw(rq, task_cfs_rq(p));
                   ^
   1 error generated.


vim +/start_hrtick_cfs_bw +8117 kernel/sched/fair.c

  8112	
  8113		if (hrtick_enabled_fair(rq))
  8114			hrtick_start_fair(rq, p);
  8115	
  8116		if (hrtick_enabled_bw(rq))
> 8117			start_hrtick_cfs_bw(rq, task_cfs_rq(p));
  8118	
  8119		update_misfit_status(p, rq);
  8120	
  8121		return p;
  8122	
  8123	idle:
  8124		if (!rf)
  8125			return NULL;
  8126	
  8127		new_tasks = newidle_balance(rq, rf);
  8128	
  8129		/*
  8130		 * Because newidle_balance() releases (and re-acquires) rq->lock, it is
  8131		 * possible for any higher priority task to appear. In that case we
  8132		 * must re-start the pick_next_entity() loop.
  8133		 */
  8134		if (new_tasks < 0)
  8135			return RETRY_TASK;
  8136	
  8137		if (new_tasks > 0)
  8138			goto again;
  8139	
  8140		/*
  8141		 * rq is about to be idle, check if we need to update the
  8142		 * lost_idle_time of clock_pelt
  8143		 */
  8144		update_idle_rq_clock_pelt(rq);
  8145	
  8146		return NULL;
  8147	}
  8148	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "config" of type "text/plain" (170719 bytes)