linux-kernel - Re: [PATCH for-next v5 3/7] RDMA/rxe: Move resp_states definition to rxe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d4f6023-0897-2414-45c0-e16b119dd9fb@gmail.com>
Date:   Thu, 18 May 2023 17:30:17 -0500
From:   Bob Pearson <rpearsonhpe@...il.com>
To:     Daisuke Matsuda <matsuda-daisuke@...itsu.com>,
        linux-rdma@...r.kernel.org, leonro@...dia.com, jgg@...dia.com,
        zyjzyj2000@...il.com
Cc:     linux-kernel@...r.kernel.org, yangx.jy@...itsu.com,
        lizhijian@...itsu.com, y-goto@...itsu.com
Subject: Re: [PATCH for-next v5 3/7] RDMA/rxe: Move resp_states definition to
 rxe_verbs.h

On 5/18/23 03:21, Daisuke Matsuda wrote:
> To use the resp_states values in rxe_loc.h, it is necessary to move the
> definition to rxe_verbs.h, where other internal states of this driver are
> defined.
> 
> Signed-off-by: Daisuke Matsuda <matsuda-daisuke@...itsu.com>
> ---
>  drivers/infiniband/sw/rxe/rxe.h       | 37 ---------------------------
>  drivers/infiniband/sw/rxe/rxe_verbs.h | 37 +++++++++++++++++++++++++++
>  2 files changed, 37 insertions(+), 37 deletions(-)
> 
> diff --git a/drivers/infiniband/sw/rxe/rxe.h b/drivers/infiniband/sw/rxe/rxe.h
> index d33dd6cf83d3..9b4d044a1264 100644
> --- a/drivers/infiniband/sw/rxe/rxe.h
> +++ b/drivers/infiniband/sw/rxe/rxe.h
> @@ -100,43 +100,6 @@
>  #define rxe_info_mw(mw, fmt, ...) ibdev_info_ratelimited((mw)->ibmw.device, \
>  		"mw#%d %s:  " fmt, (mw)->elem.index, __func__, ##__VA_ARGS__)
>  
> -/* responder states */
> -enum resp_states {
> -	RESPST_NONE,
> -	RESPST_GET_REQ,
> -	RESPST_CHK_PSN,
> -	RESPST_CHK_OP_SEQ,
> -	RESPST_CHK_OP_VALID,
> -	RESPST_CHK_RESOURCE,
> -	RESPST_CHK_LENGTH,
> -	RESPST_CHK_RKEY,
> -	RESPST_EXECUTE,
> -	RESPST_READ_REPLY,
> -	RESPST_ATOMIC_REPLY,
> -	RESPST_ATOMIC_WRITE_REPLY,
> -	RESPST_PROCESS_FLUSH,
> -	RESPST_COMPLETE,
> -	RESPST_ACKNOWLEDGE,
> -	RESPST_CLEANUP,
> -	RESPST_DUPLICATE_REQUEST,
> -	RESPST_ERR_MALFORMED_WQE,
> -	RESPST_ERR_UNSUPPORTED_OPCODE,
> -	RESPST_ERR_MISALIGNED_ATOMIC,
> -	RESPST_ERR_PSN_OUT_OF_SEQ,
> -	RESPST_ERR_MISSING_OPCODE_FIRST,
> -	RESPST_ERR_MISSING_OPCODE_LAST_C,
> -	RESPST_ERR_MISSING_OPCODE_LAST_D1E,
> -	RESPST_ERR_TOO_MANY_RDMA_ATM_REQ,
> -	RESPST_ERR_RNR,
> -	RESPST_ERR_RKEY_VIOLATION,
> -	RESPST_ERR_INVALIDATE_RKEY,
> -	RESPST_ERR_LENGTH,
> -	RESPST_ERR_CQ_OVERFLOW,
> -	RESPST_ERROR,
> -	RESPST_DONE,
> -	RESPST_EXIT,
> -};
> -
>  void rxe_set_mtu(struct rxe_dev *rxe, unsigned int dev_mtu);
>  
>  int rxe_add(struct rxe_dev *rxe, unsigned int mtu, const char *ibdev_name);
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
> index 26a20f088692..b6fbd9b3d086 100644
> --- a/drivers/infiniband/sw/rxe/rxe_verbs.h
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
> @@ -127,6 +127,43 @@ struct rxe_comp_info {
>  	struct rxe_task		task;
>  };
>  
> +/* responder states */
> +enum resp_states {
> +	RESPST_NONE,
> +	RESPST_GET_REQ,
> +	RESPST_CHK_PSN,
> +	RESPST_CHK_OP_SEQ,
> +	RESPST_CHK_OP_VALID,
> +	RESPST_CHK_RESOURCE,
> +	RESPST_CHK_LENGTH,
> +	RESPST_CHK_RKEY,
> +	RESPST_EXECUTE,
> +	RESPST_READ_REPLY,
> +	RESPST_ATOMIC_REPLY,
> +	RESPST_ATOMIC_WRITE_REPLY,
> +	RESPST_PROCESS_FLUSH,
> +	RESPST_COMPLETE,
> +	RESPST_ACKNOWLEDGE,
> +	RESPST_CLEANUP,
> +	RESPST_DUPLICATE_REQUEST,
> +	RESPST_ERR_MALFORMED_WQE,
> +	RESPST_ERR_UNSUPPORTED_OPCODE,
> +	RESPST_ERR_MISALIGNED_ATOMIC,
> +	RESPST_ERR_PSN_OUT_OF_SEQ,
> +	RESPST_ERR_MISSING_OPCODE_FIRST,
> +	RESPST_ERR_MISSING_OPCODE_LAST_C,
> +	RESPST_ERR_MISSING_OPCODE_LAST_D1E,
> +	RESPST_ERR_TOO_MANY_RDMA_ATM_REQ,
> +	RESPST_ERR_RNR,
> +	RESPST_ERR_RKEY_VIOLATION,
> +	RESPST_ERR_INVALIDATE_RKEY,
> +	RESPST_ERR_LENGTH,
> +	RESPST_ERR_CQ_OVERFLOW,
> +	RESPST_ERROR,
> +	RESPST_DONE,
> +	RESPST_EXIT,
> +};
> +
>  enum rdatm_res_state {
>  	rdatm_res_state_next,
>  	rdatm_res_state_new,

Looks OK.

Reviewed-by: Bob Pearson <rpearsonhpe@...il.com>