linux-kernel - Re: [PATCH] ACPI: resource: Remove "Zen" specific match and quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJsYDVKsZyKR_EcgfqV=sptnFmWawY5uy27KtTK3ZrjGWGYygw@mail.gmail.com>
Date:   Thu, 18 May 2023 11:54:10 +0800
From:   Chuanhong Guo <gch981213@...il.com>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     rafael@...nel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, regressions@...mhuis.info,
        ofenfisch@...glemail.com, wse@...edocomputers.com,
        adam.niederer@...il.com, adrian@...und.io, jirislaby@...nel.org,
        Renjith.Pananchikkal@....com, anson.tsao@....com,
        Richard.Gong@....com, evilsnoo@...ton.me, ruinairas1992@...il.com
Subject: Re: [PATCH] ACPI: resource: Remove "Zen" specific match and quirks

Hi!

On Tue, May 16, 2023 at 5:38 AM Mario Limonciello
<mario.limonciello@....com> wrote:
>
> commit 9946e39fe8d0 ("ACPI: resource: skip IRQ override on
> AMD Zen platforms") attempted to overhaul the override logic so it
> didn't apply on X86 AMD Zen systems.  This was intentional so that
> systems would prefer DSDT values instead of default MADT value for
> IRQ 1 on Ryzen 6000 systems which use ActiveLow for IRQ1.
>
> This turned out to be a bad assumption because several vendors seem
> to add Interrupt Source Override but don't fix the DSDT. A pile of
> quirks was collecting that proved this wasn't sustaintable.
>
> Adjust the logic so that only IRQ1 is overridden in Ryzen 6000 case.
>
> This effectively reverts the following commits:
> commit 17bb7046e7ce ("ACPI: resource: Do IRQ override on all TongFang
> GMxRGxx")
> commit f3cb9b740869 ("ACPI: resource: do IRQ override on Lenovo 14ALC7")
> commit bfcdf58380b1 ("ACPI: resource: do IRQ override on LENOVO IdeaPad")
> commit 7592b79ba4a9 ("ACPI: resource: do IRQ override on XMG Core 15")
>
> Cc: ofenfisch@...glemail.com
> Cc: gch981213@...il.com
> Cc: wse@...edocomputers.com
> Cc: adam.niederer@...il.com
> Cc: adrian@...und.io
> Cc: jirislaby@...nel.org
> Tested-by: Renjith.Pananchikkal@....com
> Tested-by: anson.tsao@....com
> Tested-by: Richard.Gong@....com
> Reported-by: evilsnoo@...ton.me
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217394
> Reported-by: ruinairas1992@...il.com
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217406
> Fixes: 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen platforms")
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Tested on Lenovo Thinkbook 14G4+ ARA with Ryzen 7 6800H.
The keyboard still works with this patch applied.

Tested-by: Chuanhong Guo <gch981213@...il.com>

-- 
Regards,
Chuanhong Guo