linux-kernel - Re: [PATCH] remoteproc: qcom: pas: mark adsp_segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c503c773-137c-0d76-9762-7ea6d3ee868c@quicinc.com>
Date:   Thu, 18 May 2023 13:17:28 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Arnd Bergmann <arnd@...nel.org>, Andy Gross <agross@...nel.org>,
        "Bjorn Andersson" <andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Sibi Sankar <quic_sibis@...cinc.com>,
        "Yogesh Lal" <quic_ylal@...cinc.com>
CC:     Arnd Bergmann <arnd@...db.de>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Abel Vesa <abel.vesa@...aro.org>,
        <linux-arm-msm@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] remoteproc: qcom: pas: mark adsp_segment_dump() static



On 5/17/2023 1:53 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The function has no other callers and should not be globally defined.
> Making it static avoids this warning:
> 
> drivers/remoteproc/qcom_q6v5_pas.c:108:6: error: no previous prototype for 'adsp_segment_dump'
> 
> Fixes: a376c10d45a8 ("remoteproc: qcom: pas: Adjust the phys addr wrt the mem region")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

This seems to be posted already

https://lore.kernel.org/lkml/20230507144826.193067-1-krzysztof.kozlowski@linaro.org/

-- Mukesh

> ---
>   drivers/remoteproc/qcom_q6v5_pas.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index e34d82b18a67..a1d69721a0e7 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -105,8 +105,9 @@ struct qcom_adsp {
>   	struct qcom_scm_pas_metadata dtb_pas_metadata;
>   };
>   
> -void adsp_segment_dump(struct rproc *rproc, struct rproc_dump_segment *segment,
> -		       void *dest, size_t offset, size_t size)
> +static void adsp_segment_dump(struct rproc *rproc,
> +			      struct rproc_dump_segment *segment,
> +			      void *dest, size_t offset, size_t size)
>   {
>   	struct qcom_adsp *adsp = rproc->priv;
>   	int total_offset;