linux-kernel - Re: [PATCH 2/3] drm/amd/display: drop unused function set_abm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e4b8bed-005e-1b12-82f4-45b5cf3e7b71@amd.com>
Date:   Wed, 17 May 2023 18:03:19 -0600
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@....com>
To:     Hamza Mahfooz <hamza.mahfooz@....com>,
        amd-gfx@...ts.freedesktop.org
Cc:     kernel test robot <lkp@...el.com>, Tom Rix <trix@...hat.com>,
        Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Qingqing Zhuo <qingqing.zhuo@....com>,
        Aurabindo Pillai <aurabindo.pillai@....com>,
        Hans de Goede <hdegoede@...hat.com>,
        Hersen Wu <hersenxs.wu@....com>,
        Stylon Wang <stylon.wang@....com>,
        Wenjing Liu <wenjing.liu@....com>,
        Leon Huang <Leon.Huang1@....com>,
        Mike Hsieh <Mike.Hsieh@....com>,
        Cruise Hung <Cruise.Hung@....com>,
        Nasir Osman <nasir.osman@....com>,
        pengfuyuan <pengfuyuan@...inos.cn>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] drm/amd/display: drop unused function set_abm_event()



On 5/17/23 12:33, Hamza Mahfooz wrote:
> set_abm_event() is never actually used. So, drop it.
> 
> Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature")
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Tom Rix <trix@...hat.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@....com>
> ---
>   drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 12 ------------
>   drivers/gpu/drm/amd/display/dc/inc/hw/abm.h   |  2 --
>   2 files changed, 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> index a66f83a61402..2fb9572ce25d 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> @@ -131,17 +131,6 @@ static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t op
>   	return ret;
>   }
>   
> -static bool dmub_abm_set_event_ex(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
> -		unsigned int hdr_mode, unsigned int panel_inst)
> -{
> -	bool ret = false;
> -	unsigned int feature_support;
> -
> -	feature_support = abm_feature_support(abm, panel_inst);
> -
> -	return ret;
> -}
> -
>   static bool dmub_abm_set_backlight_level_pwm_ex(struct abm *abm,
>   		unsigned int backlight_pwm_u16_16,
>   		unsigned int frame_ramp,
> @@ -167,7 +156,6 @@ static const struct abm_funcs abm_funcs = {
>   	.init_abm_config = dmub_abm_init_config_ex,
>   	.set_abm_pause = dmub_abm_set_pause_ex,
>   	.set_pipe_ex = dmub_abm_set_pipe_ex,
> -	.set_abm_event = dmub_abm_set_event_ex,
>   	.set_backlight_level_pwm = dmub_abm_set_backlight_level_pwm_ex,
>   };
>   
> diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> index db5cf9acafe6..d2190a3320f6 100644
> --- a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> @@ -59,8 +59,6 @@ struct abm_funcs {
>   			unsigned int otg_inst,
>   			unsigned int option,
>   			unsigned int panel_inst);
> -	bool (*set_abm_event)(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
> -			unsigned int hdr_mode, unsigned int panel_inst);
>   };
>   
>   #endif

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@....com>