linux-kernel - Re: [RFC PATCH 2/8] vhost/vhost_task: Hook vhost layer into signal handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230518-zuschauen-windhund-48949c34a524@brauner>
Date:   Thu, 18 May 2023 10:16:32 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Mike Christie <michael.christie@...cle.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>, oleg@...hat.com,
        linux@...mhuis.info, nicolas.dichtel@...nd.com, axboe@...nel.dk,
        ebiederm@...ssion.com, linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, mst@...hat.com,
        sgarzare@...hat.com, jasowang@...hat.com, stefanha@...hat.com
Subject: Re: [RFC PATCH 2/8] vhost/vhost_task: Hook vhost layer into signal
 handler

On Wed, May 17, 2023 at 08:01:45PM -0500, Mike Christie wrote:
> On 5/17/23 7:16 PM, Linus Torvalds wrote:
> > On Wed, May 17, 2023 at 5:09 PM Mike Christie
> > <michael.christie@...cle.com> wrote:
> >>
> >> +       __set_current_state(TASK_RUNNING);
> >> +       rc = get_signal(&ksig);
> >> +       set_current_state(TASK_INTERRUPTIBLE);
> >> +       return rc;
> > 
> > The games with current_state seem nonsensical.
> > 
> > What are they all about? get_signal() shouldn't care, and no other
> > caller does this thing. This just seems completely random.
> 
> Sorry. It's a leftover.
> 
> I was originally calling this from vhost_task_should_stop where before
> calling that function we do a:
> 
> set_current_state(TASK_INTERRUPTIBLE);
> 
> So, I was hitting get_signal->try_to_freeze->might_sleep->__might_sleep
> and was getting the "do not call blocking ops when !TASK_RUNNING"
> warnings.

Also seems you might want to check the return value of you new helper...