| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <36fcef74ba3d21250f4c9605e691d1e2dac20ebb.camel@maquefel.me>
Date: Thu, 18 May 2023 15:09:14 +0300
From: Nikita Shubin <nikita.shubin@...uefel.me>
To: Inochi Amaoto <inochiama@...look.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Ian Rogers <irogers@...gle.com>,
Adrian Hunter <adrian.hunter@...el.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Nikita Shubin <n.shubin@...ro.com>,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
linux-riscv@...ts.infradead.org
Subject: Re: [PATCH V3] perf vendor events riscv: add T-HEAD C9xx JSON file
Hello Inochi Amaoto!
Tested your latest patch on LicheeRV C906:
linux $ git describe --tags
v6.4-rc2-1-g85a420ada3a8
opensbi $ git describe --tags
v1.2-119-gdc1c7db
stat_all_pmu.sh - PASSED
Perf stat gives something:
perf stat -e data_tlb_miss,inst_tlb_miss,jtlb_miss,l1_dcache_read_acc
ess,l1_dcache_read_miss,l1_dcache_write_access,l1_dcache_write_miss,l1_
icache_ac
cess,l1_icache_miss -- sleep 1
Performance counter stats for 'sleep 1':
9082 data_tlb_miss
5604 inst_tlb_miss
1790 jtlb_miss
130207 l1_dcache_read_access
3353 l1_dcache_read_miss
80454 l1_dcache_write_access
633 l1_dcache_write_miss
639820 l1_icache_access
14660 l1_icache_miss
1.009768750 seconds time elapsed
0.000000000 seconds user
0.010388000 seconds sys
perf record hangs
licheerv # perf record
[ 432.015618] watchdog: BUG: soft lockup - CPU#0 stuck for 26s!
[perf:117]
[ 460.015617] watchdog: BUG: soft lockup - CPU#0 stuck for 52s!
[perf:117]
[ 488.015616] watchdog: BUG: soft lockup - CPU#0 stuck for 78s!
[perf:117]
[ 516.015617] watchdog: BUG: soft lockup - CPU#0 stuck for 104s!
[perf:117]
But that's not related to your patch anyway.
I am strongly against using "c9xx" wildcard, i would prefer declaring
them separate (especially taking in mind that c920 is c910 with vector
- AFAIK), but that's up to Arnaldo to decide.
Anyway:
Tested-by: Nikita Shubin <n.shubin@...ro.com>
On Wed, 2023-05-17 at 15:12 +0800, Inochi Amaoto wrote:
> Add json file of T-HEAD C9xx series events.
>
> The event idx (raw value) is summary as following:
>
> event id range | support cpu
> 0x01 - 0x06 | c906,c910,c920
> 0x07 | c906
> 0x08 - 0x0a | c910,c920
> 0x0b - 0x0f | c906,c910,c920
> 0x10 - 0x1a | c910,c920
> 0x1b - 0x1c | c910,c920 (software defined for all >= 0x1b)
> 0x1d - 0x2a | c906
>
> The event ids are based on the public document of T-HEAD and cover
> the c9xx series.
>
> These events are the max that c9xx series support.
> Since T-HEAD let manufacturers decide whether events are usable,
> the final support of the perf events is determined by the pmu node
> of the soc dtb.
>
> Signed-off-by: Inochi Amaoto <inochiama@...look.com>
> ---
> Change from v2:
> 1. add C906 0x07 events to the instruction.json file
> 2. fix name for events 0x07 and 0x09 in instruction.json
>
> Example:
>
> This pmu node example can be used on sophgo sg2042 platform (c920)
> with
> mainline OpenSBI.
> It should also work on T-HEAD th1520.
>
> For the one use C906 core. Only event 0x01 - 0x07, 0xb - 0xf has
> known
> CSR mapping. The other events do not have known CSR mapping in
> document
> until now.
> This pmu node needs to be shorten to adopt c906
>
> pmu {
> compatible = "riscv,pmu";
> riscv,event-to-mhpmcounters =
> // event-start event-end a bitmap of all the
> MHPMCOUNTERx
> <0x00006 0x00006 0x00000400>,
> <0x00005 0x00005 0x00000800>,
> <0x10000 0x10000 0x00004000>,
> <0x10001 0x10001 0x00008000>,
> <0x10002 0x10002 0x00010000>,
> <0x10003 0x10003 0x00020000>,
> <0x10008 0x10008 0x00000008>,
> <0x10009 0x10009 0x00000010>,
> <0x10010 0x10010 0x00040000>,
> <0x10011 0x10011 0x00080000>,
> <0x10012 0x10012 0x00100000>,
> <0x10013 0x10013 0x00200000>,
> <0x10019 0x10019 0x00000040>,
> <0x10021 0x10021 0x00000020>;
> riscv,event-to-mhpmevent =
> // event-id event-selector
> /* mhpmevent3: L1I_READ_ACCESS */
> <0x10008 0x00000000 0x00000001>,
> /* mhpmevent4: L1I_READ_MISS */
> <0x10009 0x00000000 0x00000002>,
> /* mhpmevent5: ITLB_READ_MISS */
> <0x10021 0x00000000 0x00000003>,
> /* mhpmevent6: DTLB_READ_MISS */
> <0x10019 0x00000000 0x00000004>,
> /* mhpmevent10: PMU_HW_BRANCH_MISSES */
> <0x00006 0x00000000 0x00000008>,
> /* mhpmevent11: PMU_HW_BRANCH_INSTRUCTIONS */
> <0x00005 0x00000000 0x00000009>,
> /* mhpmevent14: L1D_READ_ACCESS */
> <0x10000 0x00000000 0x0000000c>,
> /* mhpmevent15: L1D_READ_MISS */
> <0x10001 0x00000000 0x0000000d>,
> /* mhpmevent16: L1D_WRITE_ACCESS */
> <0x10002 0x00000000 0x0000000e>,
> /* mhpmevent17: L1D_WRITE_MISS */
> <0x10003 0x00000000 0x0000000f>,
> /* mhpmevent18: LL_READ_ACCESS */
> <0x10010 0x00000000 0x00000010>,
> /* mhpmevent19: LL_READ_MISS */
> <0x10011 0x00000000 0x00000011>,
> /* mhpmevent20: LL_WRITE_ACCESS */
> <0x10012 0x00000000 0x00000012>,
> /* mhpmevent21: LL_WRITE_MISS */
> <0x10013 0x00000000 0x00000013>;
> riscv,raw-event-to-mhpmcounters =
> /* mhpmevent3: L1 ICache Access Counter */
> <0x00000000 0x00000001 0xffffffff 0xffffffff
> 0x00000008>,
> /* mhpmevent4: L1 ICache Miss Counter */
> <0x00000000 0x00000002 0xffffffff 0xffffffff
> 0x00000010>,
> /* mhpmevent5: I-UTLB Miss Counter */
> <0x00000000 0x00000003 0xffffffff 0xffffffff
> 0x00000020>,
> /* mhpmevent6: D-UTLB Miss Counter */
> <0x00000000 0x00000004 0xffffffff 0xffffffff
> 0x00000040>,
> /* mhpmevent7: JTLB Miss */
> <0x00000000 0x00000005 0xffffffff 0xffffffff
> 0x00000080>,
> /* mhpmevent8: Conditional Branch Mispredict */
> <0x00000000 0x00000006 0xffffffff 0xffffffff
> 0x00000100>,
> /* mhpmevent9: Conditional Branch Instruction Counter
> (reserved for c910)*/
> /* <0x00000000 0x00000007 0xffffffff 0xffffffff
> 0x00000200>, */
> /* mhpmevent10: Indirect Branch Mispredict Counter */
> <0x00000000 0x00000008 0xffffffff 0xffffffff
> 0x00000400>,
> /* mhpmevent11: Indirect Branch Instruction Counter
> */
> <0x00000000 0x00000009 0xffffffff 0xffffffff
> 0x00000800>,
> /* mhpmevent12: LSU Spec Fail */
> <0x00000000 0x0000000a 0xffffffff 0xffffffff
> 0x00001000>,
> /* mhpmevent13: Store Instruction */
> <0x00000000 0x0000000b 0xffffffff 0xffffffff
> 0x00002000>,
> /* mhpmevent14: L1 DCache read access Counter */
> <0x00000000 0x0000000c 0xffffffff 0xffffffff
> 0x00004000>,
> /* mhpmevent15: L1 DCache read miss Counter */
> <0x00000000 0x0000000d 0xffffffff 0xffffffff
> 0x00008000>,
> /* mhpmevent16: L1 DCache write access Counter */
> <0x00000000 0x0000000e 0xffffffff 0xffffffff
> 0x00010000>,
> /* mhpmevent17: L1 DCache write access Counter */
> <0x00000000 0x0000000f 0xffffffff 0xffffffff
> 0x00020000>,
> /* mhpmevent18: L2 Cache read access Counter */
> <0x00000000 0x00000010 0xffffffff 0xffffffff
> 0x00040000>,
> /* mhpmevent19: L2 Cache read miss Counter */
> <0x00000000 0x00000011 0xffffffff 0xffffffff
> 0x00080000>,
> /* mhpmevent20: L2 Cache write access Counter */
> <0x00000000 0x00000012 0xffffffff 0xffffffff
> 0x00100000>,
> /* mhpmevent21: L2 Cache write miss Counter */
> <0x00000000 0x00000013 0xffffffff 0xffffffff
> 0x00200000>,
> /* mhpmevent22: RF Launch Fail */
> <0x00000000 0x00000014 0xffffffff 0xffffffff
> 0x00400000>,
> /* mhpmevent23: RF Reg Launch Fail */
> <0x00000000 0x00000015 0xffffffff 0xffffffff
> 0x00800000>,
> /* mhpmevent24: RF Instruction */
> <0x00000000 0x00000016 0xffffffff 0xffffffff
> 0x01000000>,
> /* mhpmevent25: LSU Cross 4K Stall */
> <0x00000000 0x00000017 0xffffffff 0xffffffff
> 0x02000000>,
> /* mhpmevent26: LSU Other Stall */
> <0x00000000 0x00000018 0xffffffff 0xffffffff
> 0x04000000>,
> /* mhpmevent27: LSU SQ Discard */
> <0x00000000 0x00000019 0xffffffff 0xffffffff
> 0x08000000>,
> /* mhpmevent28: LSU SQ Data Discard */
> <0x00000000 0x0000001a 0xffffffff 0xffffffff
> 0x10000000>;
> };
>
> ---
> tools/perf/pmu-events/arch/riscv/mapfile.csv | 1 +
> .../arch/riscv/t-head/c9xx/cache.json | 67 +++++++++++++++++
> .../arch/riscv/t-head/c9xx/firmware.json | 68
> ++++++++++++++++++
> .../arch/riscv/t-head/c9xx/instruction.json | 72
> +++++++++++++++++++
> .../arch/riscv/t-head/c9xx/microarch.json | 67 +++++++++++++++++
> 5 files changed, 275 insertions(+)
> create mode 100644 tools/perf/pmu-events/arch/riscv/t-
> head/c9xx/cache.json
> create mode 100644 tools/perf/pmu-events/arch/riscv/t-
> head/c9xx/firmware.json
> create mode 100644 tools/perf/pmu-events/arch/riscv/t-
> head/c9xx/instruction.json
> create mode 100644 tools/perf/pmu-events/arch/riscv/t-
> head/c9xx/microarch.json
>
> diff --git a/tools/perf/pmu-events/arch/riscv/mapfile.csv
> b/tools/perf/pmu-events/arch/riscv/mapfile.csv
> index c61b3d6ef616..dd1d998a7ad6 100644
> --- a/tools/perf/pmu-events/arch/riscv/mapfile.csv
> +++ b/tools/perf/pmu-events/arch/riscv/mapfile.csv
> @@ -15,3 +15,4 @@
> #
> #MVENDORID-MARCHID-MIMPID,Version,Filename,EventType
> 0x489-0x8000000000000007-0x[[:xdigit:]]+,v1,sifive/u74,core
> +0x5b7-0x0-0x0,v1,t-head/c9xx,core
> diff --git a/tools/perf/pmu-events/arch/riscv/t-head/c9xx/cache.json
> b/tools/perf/pmu-events/arch/riscv/t-head/c9xx/cache.json
> new file mode 100644
> index 000000000000..2c6e9a904a11
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/riscv/t-head/c9xx/cache.json
> @@ -0,0 +1,67 @@
> +[
> + {
> + "EventName": "L1_ICACHE_ACCESS",
> + "EventCode": "0x000001",
> + "BriefDescription": "L1 instruction cache access"
> + },
> + {
> + "EventName": "L1_ICACHE_MISS",
> + "EventCode": "0x000002",
> + "BriefDescription": "L1 instruction cache miss"
> + },
> + {
> + "EventName": "INST_TLB_MISS",
> + "EventCode": "0x000003",
> + "BriefDescription": "Instruction TLB (I-UTLB) miss"
> + },
> + {
> + "EventName": "DATA_TLB_MISS",
> + "EventCode": "0x000004",
> + "BriefDescription": "Data TLB (D-UTLB) miss"
> + },
> + {
> + "EventName": "JTLB_MISS",
> + "EventCode": "0x000005",
> + "BriefDescription": "JTLB access miss"
> + },
> + {
> + "EventName": "L1_DCACHE_READ_ACCESS",
> + "EventCode": "0x00000c",
> + "BriefDescription": "L1 data cache read access"
> + },
> + {
> + "EventName": "L1_DCACHE_READ_MISS",
> + "EventCode": "0x00000d",
> + "BriefDescription": "L1 data cache read miss"
> + },
> + {
> + "EventName": "L1_DCACHE_WRITE_ACCESS",
> + "EventCode": "0x00000e",
> + "BriefDescription": "L1 data cache write access"
> + },
> + {
> + "EventName": "L1_DCACHE_WRITE_MISS",
> + "EventCode": "0x00000f",
> + "BriefDescription": "L1 data cache write miss"
> + },
> + {
> + "EventName": "L2_CACHE_READ_ACCESS",
> + "EventCode": "0x000010",
> + "BriefDescription": "L2 cache read access"
> + },
> + {
> + "EventName": "L2_CACHE_READ_MISS",
> + "EventCode": "0x000011",
> + "BriefDescription": "L2 cache read miss"
> + },
> + {
> + "EventName": "L2_CACHE_WRITE_ACCESS",
> + "EventCode": "0x000012",
> + "BriefDescription": "L2 cache write access"
> + },
> + {
> + "EventName": "L2_CACHE_WRITE_MISS",
> + "EventCode": "0x000013",
> + "BriefDescription": "L2 cache write miss"
> + }
> +]
> diff --git a/tools/perf/pmu-events/arch/riscv/t-
> head/c9xx/firmware.json b/tools/perf/pmu-events/arch/riscv/t-
> head/c9xx/firmware.json
> new file mode 100644
> index 000000000000..9b4a032186a7
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/riscv/t-head/c9xx/firmware.json
> @@ -0,0 +1,68 @@
> +[
> + {
> + "ArchStdEvent": "FW_MISALIGNED_LOAD"
> + },
> + {
> + "ArchStdEvent": "FW_MISALIGNED_STORE"
> + },
> + {
> + "ArchStdEvent": "FW_ACCESS_LOAD"
> + },
> + {
> + "ArchStdEvent": "FW_ACCESS_STORE"
> + },
> + {
> + "ArchStdEvent": "FW_ILLEGAL_INSN"
> + },
> + {
> + "ArchStdEvent": "FW_SET_TIMER"
> + },
> + {
> + "ArchStdEvent": "FW_IPI_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_IPI_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_FENCE_I_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_FENCE_I_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_SFENCE_VMA_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_SFENCE_VMA_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_SFENCE_VMA_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_SFENCE_VMA_ASID_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_GVMA_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_GVMA_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_GVMA_VMID_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_GVMA_VMID_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_VVMA_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_VVMA_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_VVMA_ASID_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_VVMA_ASID_RECEIVED"
> + }
> +]
> diff --git a/tools/perf/pmu-events/arch/riscv/t-
> head/c9xx/instruction.json b/tools/perf/pmu-events/arch/riscv/t-
> head/c9xx/instruction.json
> new file mode 100644
> index 000000000000..7f1649548177
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/riscv/t-head/c9xx/instruction.json
> @@ -0,0 +1,72 @@
> +[
> + {
> + "EventName": "BR_COND_MIS_PRED",
> + "EventCode": "0x000006",
> + "BriefDescription": "Conditional branch mispredict"
> + },
> + {
> + "EventName": "INST_BR_COND_MIS",
> + "EventCode": "0x000007",
> + "BriefDescription": "Conditional branch instruction"
> + },
> + {
> + "EventName": "BR_INDIRECT_MIS_PRED",
> + "EventCode": "0x000008",
> + "BriefDescription": "Indirect branch mispredict"
> + },
> + {
> + "EventName": "INST_BR_COND_MIS",
> + "EventCode": "0x000009",
> + "BriefDescription": "Indirect branch instruction"
> + },
> + {
> + "EventName": "INST_STORE",
> + "EventCode": "0x00000b",
> + "BriefDescription": "Store instruction retired"
> + },
> + {
> + "EventName": "INST_ALU",
> + "EventCode": "0x00001d",
> + "BriefDescription": "ALU instruction retired"
> + },
> + {
> + "EventName": "INST_LOAD_SAVE",
> + "EventCode": "0x00001e",
> + "BriefDescription": "LOAD/Store instruction retired"
> + },
> + {
> + "EventName": "INST_VECTOR",
> + "EventCode": "0x00001f",
> + "BriefDescription": "Vector instruction retired"
> + },
> + {
> + "EventName": "INST_CSR_ACCESS",
> + "EventCode": "0x000020",
> + "BriefDescription": "CSR access instruction retired"
> + },
> + {
> + "EventName": "INST_SYNC",
> + "EventCode": "0x000021",
> + "BriefDescription": "Sync instruction retired"
> + },
> + {
> + "EventName": "INST_LOAD_SAVE_UNALIGNED",
> + "EventCode": "0x000022",
> + "BriefDescription": "Load/Store unaligned access instruction
> retired"
> + },
> + {
> + "EventName": "INST_ENV_CALL",
> + "EventCode": "0x000025",
> + "BriefDescription": "Environment call instruction retired"
> + },
> + {
> + "EventName": "INST_LONGJUMP",
> + "EventCode": "0x000026",
> + "BriefDescription": "Long jump instruction retired (jump dist
> over 8MB)"
> + },
> + {
> + "EventName": "INST_FP",
> + "EventCode": "0x00002a",
> + "BriefDescription": "Float point instruction retired"
> + }
> +]
> diff --git a/tools/perf/pmu-events/arch/riscv/t-
> head/c9xx/microarch.json b/tools/perf/pmu-events/arch/riscv/t-
> head/c9xx/microarch.json
> new file mode 100644
> index 000000000000..073c1d085021
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/riscv/t-head/c9xx/microarch.json
> @@ -0,0 +1,67 @@
> +[
> + {
> + "EventName": "LSU_SPEC_FAIL",
> + "EventCode": "0x00000a",
> + "BriefDescription": "LSU Spec Fail"
> + },
> + {
> + "EventName": "RF_LAUNCH_FAIL",
> + "EventCode": "0x000014",
> + "BriefDescription": "Register file launch fail"
> + },
> + {
> + "EventName": "RF_REG_LAUNCH",
> + "EventCode": "0x000015",
> + "BriefDescription": "Register file reg launch"
> + },
> + {
> + "EventName": "RF_INSTRUCTION",
> + "EventCode": "0x000016",
> + "BriefDescription": "Register file instruction"
> + },
> + {
> + "EventName": "LSU_STALL_CROSS_4K",
> + "EventCode": "0x000017",
> + "BriefDescription": "LSU stall with cross 4K access"
> + },
> + {
> + "EventName": "LSU_STALL_OTHER",
> + "EventCode": "0x000018",
> + "BriefDescription": "LSU stall with other events"
> + },
> + {
> + "EventName": "LSU_SQ_DISCARD",
> + "EventCode": "0x000019",
> + "BriefDescription": "LSU SQ discard"
> + },
> + {
> + "EventName": "LSU_SQ_DISCARD_DATA",
> + "EventCode": "0x00001a",
> + "BriefDescription": "LSU SQ data discard"
> + },
> + {
> + "EventName": "INT_NUMBER",
> + "EventCode": "0x000023",
> + "BriefDescription": "Interrupt number respond"
> + },
> + {
> + "EventName": "INT_OFF_CYCLE",
> + "EventCode": "0x000024",
> + "BriefDescription": "Off cycle before interrupt arbitrating"
> + },
> + {
> + "EventName": "STALLED_CYCLE_IFU",
> + "EventCode": "0x000027",
> + "BriefDescription": "Stall cycles of the instruction fetch unit"
> + },
> + {
> + "EventName": "STALLED_CYCLE_IDU",
> + "EventCode": "0x000028",
> + "BriefDescription": "Stall cycles of the instruction decoding
> unit and next-level pipeline unit"
> + },
> + {
> + "EventName": "STALLED_CYCLE_SYNC",
> + "EventCode": "0x000029",
> + "BriefDescription": "Stalled cycle for sync instructions
> (FENCE/FENCE.i/SFENCE/SYNC...)"
> + }
> +]
> --
> 2.40.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Powered by blists - more mailing lists