linux-kernel - Re: [PATCH v4 2/2] leds: add aw20xx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdEc9x=v-NU4wqrg-S0vEjqc27JPqZAK0TJsNUc37ZTmg@mail.gmail.com>
Date:   Thu, 18 May 2023 13:44:11 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Martin Kurbanov <mmkurbanov@...rdevices.ru>
Cc:     Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, kernel@...rdevices.ru
Subject: Re: [PATCH v4 2/2] leds: add aw20xx driver

On Wed, May 17, 2023 at 10:52 PM Martin Kurbanov
<mmkurbanov@...rdevices.ru> wrote:
>
> This commit adds support for AWINIC AW20036/AW20054/AW20072 LED driver.
> This driver supports following AW200XX features:
>   - Individual 64-level DIM currents

With or without below
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

...

> +static int aw200xx_probe_dt(struct device *dev, struct aw200xx *chip)

_dt is not fully correct suffix, it's now firmware properties, so perhaps _fw?

...

I would do

  i = 0;

here and drop the assignment in the definition block to be more robust
against sudden reuse of i in between.

> +       device_for_each_child_node(dev, child) {

> +               i++;
> +       }

-- 
With Best Regards,
Andy Shevchenko