linux-kernel - Re: [PATCH] dmaengine: ste_dma40: use proper format string for resource_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2b7eef56-9409-46bd-bcf7-dea054adfccd@app.fastmail.com>
Date:   Thu, 18 May 2023 13:59:08 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Vinod Koul" <vkoul@...nel.org>, "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Linus Walleij" <linus.walleij@...aro.org>,
        "Julia Lawall" <Julia.Lawall@...ia.fr>,
        linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: ste_dma40: use proper format string for resource_size_t

On Thu, May 18, 2023, at 13:29, Vinod Koul wrote:
> On 17-05-23, 22:19, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> When LPAE is set, both the dma_addr_t and resource_size_t become 64 bit
>> wide, causing a warning about the format string:
>> 
>> drivers/dma/ste_dma40.c: In function 'd40_probe':
>> drivers/dma/ste_dma40.c:3539:23: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
>>  3539 |         dev_info(dev, "found LCPA SRAM at 0x%08x, size 0x%08x\n",
>> 
>> Change both to the special %pap and %pap helpers for these types.
>
> Already posted [1] and applied now
>
> [1]: https://lore.kernel.org/r/20230517064434.141091-1-vkoul@kernel.org

I think yours is wrong: you use %pR with a resource_size_t, but it
expects a "struct resource instead".

      Arnd