linux-kernel - Re: [PATCH] sched: core: Simplify cpuset_cpumask_can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69f2db7c-bc3d-b08c-c85d-66bb32c3766a@quicinc.com>
Date:   Thu, 18 May 2023 19:14:01 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Li zeming <zeming@...china.com>, <mingo@...hat.com>,
        <peterz@...radead.org>, <juri.lelli@...hat.com>,
        <vincent.guittot@...aro.org>, <dietmar.eggemann@....com>,
        <rostedt@...dmis.org>, <bsegall@...gle.com>, <mgorman@...e.de>,
        <bristot@...hat.com>, <vschneid@...hat.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched: core: Simplify cpuset_cpumask_can_shrink()



On 5/19/2023 2:04 AM, Li zeming wrote:
> Remove useless intermediate variable "ret" and its initialization.
> Directly return dl_cpuset_cpumask_can_shrink() result.
> 
> Signed-off-by: Li zeming <zeming@...china.com>

Acked-by : Mukesh Ojha <quic_mojha@...cinc.com>

-Mukesh
> ---
>   kernel/sched/core.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index a66960da3f5c..f3f2ece26291 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -9273,14 +9273,10 @@ void __init init_idle(struct task_struct *idle, int cpu)
>   int cpuset_cpumask_can_shrink(const struct cpumask *cur,
>   			      const struct cpumask *trial)
>   {
> -	int ret = 1;
> -
>   	if (cpumask_empty(cur))
> -		return ret;
> -
> -	ret = dl_cpuset_cpumask_can_shrink(cur, trial);
> +		return 1;
>   
> -	return ret;
> +	return dl_cpuset_cpumask_can_shrink(cur, trial);
>   }
>   
>   int task_can_attach(struct task_struct *p,