linux-kernel - Re: [PATCH] ALSA: emu10k1: set variables emu1010_routing_info and emu1010_pads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wn15hfsd.wl-tiwai@suse.de>
Date:   Thu, 18 May 2023 16:31:46 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Oswald Buddenhagen <oswald.buddenhagen@....de>
Cc:     Tom Rix <trix@...hat.com>, perex@...ex.cz, tiwai@...e.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: emu10k1: set variables emu1010_routing_info and emu1010_pads_info storage-class-specifier to static

On Thu, 18 May 2023 15:58:51 +0200,
Oswald Buddenhagen wrote:
> 
> On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote:
> > smatch reports
>  ^^^^^^ is this the best word to use here?

Note that smatch is a name of a static analysis tool :)

> > sound/pci/emu10k1/emumixer.c:519:39: warning: symbol
> >  'emu1010_routing_info' was not declared. Should it be static?
> > sound/pci/emu10k1/emumixer.c:859:36: warning: symbol
> >  'emu1010_pads_info' was not declared. Should it be static?
> > 
> > These variables are only used in their defining file, so it should be static
> 							  ^^ they
> > 
> > Signed-off-by: Tom Rix <trix@...hat.com>
> > 
> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@....de>
> 
> (also amending one of the still pending patches. thanks!)

Applied the patch now, thanks.


Takashi