linux-kernel - Re: [PATCH] LoongArch: Select HAVE_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 May 2023 10:10:50 +0800
From:   Huacai Chen <chenhuacai@...nel.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Youling Tang <tangyouling@...ngson.cn>,
        Catalin Marinas <catalin.marinas@....com>,
        WANG Xuerui <kernel@...0n.name>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org, loongson-kernel@...ts.loongnix.cn,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Select HAVE_DEBUG_KMEMLEAK to support kmemleak

Queued, thanks.

Huacai

On Tue, May 9, 2023 at 3:43 PM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>
> Cc: Jonathan Corbet <corbet@....net>
>      linux-doc@...r.kernel.org
>
> On 05/09/2023 03:13 PM, Youling Tang wrote:
> > Hi, Tiezhu
> >
> > On 05/09/2023 02:49 PM, Tiezhu Yang wrote:
> >> We can see that DEBUG_KMEMLEAK depends on HAVE_DEBUG_KMEMLEAK after
> >> commit b69ec42b1b19 ("Kconfig: clean up the long arch list for the
> >> DEBUG_KMEMLEAK config option"), just select HAVE_DEBUG_KMEMLEAK to
> >> support kmemleak on LoongArch.
> >>
> >> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> >> ---
> >>
> >> This is based on 6.4-rc1
> >>
> >>  arch/loongarch/Kconfig | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> >> index d38b066..1e64edd 100644
> >> --- a/arch/loongarch/Kconfig
> >> +++ b/arch/loongarch/Kconfig
> >> @@ -90,6 +90,7 @@ config LOONGARCH
> >>      select HAVE_ASM_MODVERSIONS
> >>      select HAVE_CONTEXT_TRACKING_USER
> >>      select HAVE_C_RECORDMCOUNT
> >> +    select HAVE_DEBUG_KMEMLEAK
> >>      select HAVE_DEBUG_STACKOVERFLOW
> >>      select HAVE_DMA_CONTIGUOUS
> >>      select HAVE_DYNAMIC_FTRACE
> >>
> >
> > At the same time, you need to modify the loongarch in arch-support.txt
> > to ok.
> >
> > BTW, we can submit a separate patch to modify the features already
> > supported by LoongArch.
> >
> > The following features are already supported in LoongArch.
> >
> > diff --git
> > a/Documentation/features/debug/kprobes-on-ftrace/arch-support.txt
> > b/Documentation/features/debug/kprobes-on-ftrace/arch-support.txt
> ...
> > diff --git a/Documentation/features/debug/kprobes/arch-support.txt
> > b/Documentation/features/debug/kprobes/arch-support.txt
> > index 8a77d62a42c5..aad83b57587a 100644
> > --- a/Documentation/features/debug/kprobes/arch-support.txt
> > +++ b/Documentation/features/debug/kprobes/arch-support.txt
> ...
> > diff --git a/Documentation/features/debug/kretprobes/arch-support.txt
> > b/Documentation/features/debug/kretprobes/arch-support.txt
> > index cf4723c5ac55..61380010a4a7 100644
> > --- a/Documentation/features/debug/kretprobes/arch-support.txt
> > +++ b/Documentation/features/debug/kretprobes/arch-support.txt
> ...
> > diff --git
> > a/Documentation/features/debug/stackprotector/arch-support.txt
> > b/Documentation/features/debug/stackprotector/arch-support.txt
> > index 71cd4ba18f7d..4c64c5d596f7 100644
> > --- a/Documentation/features/debug/stackprotector/arch-support.txt
> > +++ b/Documentation/features/debug/stackprotector/arch-support.txt
>
> Thank you, I have already prepared a patch to update the docs,
> but some more features will be added on LoongArch in the following
> merge window, I am not sure what is the proper time to send the
> following patch, maybe two months later, or right away, maybe
> Jonathan can give some suggestions.
>
> Documentation/features: Refresh LoongArch support files
>
> Run the refresh script [1] to document the recent feature additions
> on LoongArch.
>
> [1] Documentation/features/scripts/features-refresh.sh
>
> Thanks,
> Tiezhu
>
>