linux-kernel - Re: [PATCH 05/20] x86: head: add dummy prototype for mk_early_pgtbl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <996ee80f-f3d0-d0f5-d045-4636c35ce9b2@intel.com>
Date:   Thu, 18 May 2023 18:52:34 +0200
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Arnd Bergmann <arnd@...nel.org>
CC:     <x86@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Juergen Gross <jgross@...e.com>,
        "Srivatsa S. Bhat (VMware)" <srivatsa@...il.mit.edu>,
        Alexey Makhalov <amakhalov@...are.com>,
        VMware PV-Drivers Reviewers <pv-drivers@...are.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-trace-kernel@...r.kernel.org>,
        <virtualization@...ts.linux-foundation.org>,
        <linux-pci@...r.kernel.org>, <platform-driver-x86@...r.kernel.org>,
        <xen-devel@...ts.xenproject.org>, <linux-pm@...r.kernel.org>,
        <linux-mm@...ck.org>
Subject: Re: [PATCH 05/20] x86: head: add dummy prototype for
 mk_early_pgtbl_32

From: Arnd Bergmann <arnd@...nel.org>
Date: Tue, 16 May 2023 21:35:34 +0200

> From: Arnd Bergmann <arnd@...db.de>
> 
> 'make W=1' warns about a function without a prototype in the x86-32 head code:
> 
> arch/x86/kernel/head32.c:72:13: error: no previous prototype for 'mk_early_pgtbl_32' [-Werror=missing-prototypes]
> 
> This is called from assembler code, so it does not actually need a prototype.
> I could not find an appropriate header for it, so just declare it in front
> of the definition to shut up th warning.

                               ^^
                               the :p

> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

I'd say, for the whole series:

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

BUT apart from the Xen part, it's all black magic rituals to me :D

Thanks,
Olek