linux-kernel - Re: [PATCH V7 4/8] pinctrl: qcom: Add IPQ5018 pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfVx+oGYKcija3h9-eWc6jggMx8p5SAQTEHTBEbjTaJKw@mail.gmail.com>
Date:   Fri, 19 May 2023 21:47:43 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sricharan Ramabadhran <quic_srichara@...cinc.com>
Cc:     agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        mturquette@...libre.com, sboyd@...nel.org, ulf.hansson@...aro.org,
        linus.walleij@...aro.org, catalin.marinas@....com, will@...nel.org,
        p.zabel@...gutronix.de, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mmc@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, robimarko@...il.com
Subject: Re: [PATCH V7 4/8] pinctrl: qcom: Add IPQ5018 pinctrl driver

On Fri, May 19, 2023 at 3:55 PM Sricharan Ramabadhran
<quic_srichara@...cinc.com> wrote:
>
> Add pinctrl definitions for the TLMM of IPQ5018.

A couple of remarks either for the next version of the series or for
the follow ups.

...

> +config PINCTRL_IPQ5018
> +       tristate "Qualcomm Technologies, Inc. IPQ5018 pin controller driver"

> +       depends on GPIOLIB && OF

I'm wondering why OF.
If it's a functional dependency (I do not see compile-time one) the
compile test can be added, no?

  depends on GPIOLIB
  depends on OF || COMPILE_TEST

> +       select PINCTRL_MSM
> +       help
> +         This is the pinctrl, pinmux, pinconf and gpiolib driver for
> +         the Qualcomm Technologies Inc. TLMM block found on the
> +         Qualcomm Technologies Inc. IPQ5018 platform. Select this for
> +         IPQ5018.

...

> +#include <linux/module.h>

> +#include <linux/of.h>

There is a wrong header (the code doesn't use this one).
You meant mod_devicetable.h

> +#include <linux/platform_device.h>

Besides that kernel.h for ARRAY_SIZE() init.h for arch_initcall() and
others might be missing.

-- 
With Best Regards,
Andy Shevchenko