linux-kernel - Re: [PATCH] riscv: hibernation: Remove duplicate call of suspend_restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 May 2023 21:07:15 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Conor Dooley <conor.dooley@...rochip.com>
Cc:     JeeHeng Sia <jeeheng.sia@...rfivetech.com>,
        Song Shuai <suagrfillet@...il.com>,
        "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "palmer@...belt.com" <palmer@...belt.com>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        Mason Huo <mason.huo@...rfivetech.com>,
        Leyfoon Tan <leyfoon.tan@...rfivetech.com>,
        "ajones@...tanamicro.com" <ajones@...tanamicro.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Song Shuai <songshuaishuai@...ylab.org>
Subject: Re: [PATCH] riscv: hibernation: Remove duplicate call of
 suspend_restore_csrs

On Fri, May 19, 2023 at 12:28:07PM +0100, Conor Dooley wrote:
> Hey,
> 
> On Fri, May 19, 2023 at 11:14:27AM +0000, JeeHeng Sia wrote:
> 
> > > The suspend_restore_csrs is called in both __hibernate_cpu_resume
> > > and the `else` of subsequent swsusp_arch_suspend.
> > > 
> > > Removing the first call makes both suspend_{save,restore}_csrs
> > > left in swsusp_arch_suspend for clean code.

It took me embarrassingly long to wrap my head around the control flow
here again. I'm not sure that I agree with you that splitting the calls
between asm & c is cleaner, but whatever:
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

> > > 
> > > Signed-off-by: Song Shuai <suagrfillet@...il.com>
> > > Signed-off-by: Song Shuai <songshuaishuai@...ylab.org>
> 
> BTW, why the two email addresses? The tinylab one here seems entirely
> redundant - unless it is your employer, in which case should it be the
> only SoB address & also in the author field?

Deja vu with my questioning your email address, but does your
tinylab address actually repeat "shuai"?

> Also, Fixes tag?
> 
> > > ---
> > >  arch/riscv/kernel/hibernate-asm.S | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/arch/riscv/kernel/hibernate-asm.S b/arch/riscv/kernel/hibernate-asm.S
> > > index 5c76671c7e15..d698dd7df637 100644
> > > --- a/arch/riscv/kernel/hibernate-asm.S
> > > +++ b/arch/riscv/kernel/hibernate-asm.S
> > > @@ -28,7 +28,6 @@ ENTRY(__hibernate_cpu_resume)
> > > 
> > >  	REG_L	a0, hibernate_cpu_context
> > > 
> > > -	suspend_restore_csrs
> > >  	suspend_restore_regs
> 
> > Good catch. This function is invoked twice to restore the CSRs.
> > I am good with removing this function from here.
> 
> If that's a review, then please either give an R-b or A-b tag :)
> 
> Thanks,
> Conor.



Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)