[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230519152715.7d1c3a49@kernel.org>
Date: Fri, 19 May 2023 15:27:15 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Min-Hua Chen <minhuadotchen@...il.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Simon Horman <simon.horman@...igine.com>,
netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] net: stmmac: compare p->des0 and p->des1 with __le32
type values
On Fri, 19 May 2023 19:50:28 +0800 Min-Hua Chen wrote:
> - if ((p->des0 == 0xffffffff) && (p->des1 == 0xffffffff))
> + if (p->des0 == cpu_to_le32(0xffffffff) &&
> + p->des1 == cpu_to_le32(0xffffffff))
Can you try to fix the sparse tool instead? I believe it already
ignores such errors for the constant of 0, maybe it can be taught
to ignore all "isomorphic" values?
By "isomorphic" I mean that 0xffffffff == cpu_to_le32(0xffffffff)
so there's no point complaining.
--
pw-bot: reject
Powered by blists - more mailing lists