linux-kernel - Re: [PATCH v5 1/1] dmaengine: switchtec-dma: Introduce Switchtec DMA engine PCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGbzf6G5OpK0mRXN@infradead.org>
Date:   Thu, 18 May 2023 20:56:47 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Kelvin Cao <kelvin.cao@...rochip.com>
Cc:     vkoul@...nel.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, logang@...tatee.com,
        george.ge@...rochip.com, christophe.jaillet@...adoo.fr,
        hch@...radead.org
Subject: Re: [PATCH v5 1/1] dmaengine: switchtec-dma: Introduce Switchtec DMA
 engine PCI driver

> +/*
> + * Use vender/device and class to identify the DMA function.
> + */
> +#define SWITCHTEC_DMA_DEVICE(device_id) \

I'd word this as:

/*
 * Also use the class code to identify the devices, as some of the
 * device IDs are also used for other devices with other classes by
 * Microsemi.
 */

to emphasis on why this macro even exists.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>