linux-kernel - Re: [PATCH] misc: fastrpc: Fix double free of 'buf' in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGcTVfAQeRcOSjO8@dev-linux.lan>
Date:   Thu, 18 May 2023 23:12:37 -0700
From:   Sukrut Bellary <sukrut.bellary@...ux.com>
To:     Dan Carpenter <dan.carpenter@...aro.org>
Cc:     Abel Vesa <abel.vesa@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Amol Maheshwari <amahesh@....qualcomm.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] misc: fastrpc: Fix double free of 'buf' in error path

On Fri, May 19, 2023 at 07:16:14AM +0300, Dan Carpenter wrote:
> On Thu, May 18, 2023 at 07:45:22PM -0700, Sukrut Bellary wrote:
> > > > 
> > > > Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
> > > > Signed-off-by: Sukrut Bellary <sukrut.bellary@...ux.com>
> > > > ---
> > >   ^^^
> > > Put testing caveats here instead, where it will be removed from the
> > > git log.
> > >
> > 
> > Shall I add "This is based on static analysis only. Compilation tested"
> > here 
> > or 
> > is it not required to mention this for all the fixes?
> > Can you please recommend what's is the preferred method I need to follow?
> 
> You can't go wrong with always adding it.  The untested part is useful
> to know.  Also it's good to know how a bug is found so we can say if
> it's affecting user and so we can improve our processes going forward.
>
Ok, that's clear. Thanks for the input.

Regards,
Sukrut Bellary

> regards,
> dan carpenter
>