linux-kernel - Re: [PATCH] caam: imx: fix the built-in caam driver cannot match soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZGc4LqAp4gvsS7qv@gondor.apana.org.au>
Date:   Fri, 19 May 2023 16:49:50 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Pankaj Gupta <pankaj.gupta@....com>
Cc:     gaurav.jain@....com, davem@...emloft.net,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-imx@....com, Alice Guo <alice.guo@....com>,
        Dong Aisheng <aisheng.dong@....com>,
        Horia Geanta <horia.geanta@....com>,
        Peng Fan <peng.fan@....com>
Subject: Re: [PATCH] caam: imx: fix the built-in caam driver cannot match
 soc_id

On Fri, May 12, 2023 at 08:40:33PM +0530, Pankaj Gupta wrote:
> Since, CAAM driver is probed before soc_device_attribute done as part of:
> - drivers/soc/imx/soc-imx8m.c   (for i.MX8M)
> - drivers/firmware/imx/ele_mu.c (EdgeLock Enclave kernel driver, for i.MX8ULP)
> 
> It is needed to return -EPROBE_DEFER, after calling soc_device_match() in
> drivers/crypto/caam/ctrl.c.
> 
> soc_device_match returns NULL for:
> - i.MX8M
> - i.MX8ULP,
> can be considered that the SoC device has not been probed yet.
> Hence, it returns -EPROBE_DEFER directly.
> 
> caam: imx: change to use of_match_node in run_descriptor_deco0
> 
> Providing imx8m_machine_match to match:
> - i.MX8M{Q,M,N,P},
> - i.MX8ULP,
> so as to start using of_match_node, to simplify the code.
> 
> Signed-off-by: Alice Guo <alice.guo@....com>
> Signed-off-by: Pankaj Gupta <pankaj.gupta@....com>
> Reviewed-by: Dong Aisheng <aisheng.dong@....com>
> Reviewed-by: Horia Geanta <horia.geanta@....com>
> Acked-by: Peng Fan <peng.fan@....com>
> ---
>  drivers/crypto/caam/ctrl.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt